Update ICP and depending libraries to fix long-running crashes #149
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the ICP repository sources, fixing several issues with ICP, mainly crashes that occur when running it for a long timespan (> 1 h).
The crashes were very sporadic and unpredictable, making them hard to pinpoint and debug. ICP mostly ended up with the message
This was particularly annoying since ICP not only had to be restarted, but also reinitialized with the current estimated pose of the robot. By that time, the state machine mostly had stopped working already since the TF tree was not connected anymore.
The PR also updates
libpointmatcher
which had other bugs fixed in upstream repositories not merged into the branch we were depending on, yet.Related: