getting rid of clang-tidy

Author: markusgft

ct/CMakeLists.txt

@@ -10,8 +10,4 @@ add_custom_target(doc
 
 add_custom_target(clang-format
         COMMAND ${CMAKE_COMMAND} -E echo_append "Running clang-format on CT..."
-        VERBATIM)
-
-add_custom_target(clang-tidy
-        COMMAND ${CMAKE_COMMAND} -E echo_append "Running clang-tidy on CT..."
-        VERBATIM)    
+        VERBATIM)

ct/cmake/clang-cxx-dev-tools.cmake

@@ -1,8 +1,8 @@
-# CLANG-TIDY AND CLANG-FORMAT
-##############################
-
-# Additional targets to perform clang-format/clang-tidy
+##############
+# CLANG-FORMAT
+##############
 
+# Additional targets to perform clang-format
 
 # function to exclude user-defined folders from the clang format- and tidy process     
 function(filter_ct_directories allItems excludeDir)
@@ -70,46 +70,3 @@ else()
     VERBATIM
     )
 endif()
-
-# Adding clang-tidy target if clang-tidy executable is found
-function(ct_configure_clang_tidy TIDY_INC_DIRS)
-
-    ct_get_all_srcs(FALSE)
-
-    set(CURRENT_INC_DIRS "")
-    
-    #message(FATAL_ERROR "Inc dirs: ${${TIDY_INC_DIRS}}")
-    
-    foreach (THIS_INC_DIR ${${TIDY_INC_DIRS}})
-        #message(WARNING "this inc dir: ${THIS_INC_DIR}")
-        list(APPEND CURRENT_INC_DIRS "-I${THIS_INC_DIR}")
-    endforeach()
-    
-    #message(FATAL_ERROR "Current inc dirs: ${CURRENT_INC_DIRS}")
-
-    find_program(CLANG_TIDY_BIN "clang-tidy")
-    if(NOT CLANG_TIDY_BIN)
-      find_program(CLANG_TIDY_BIN "clang-tidy-3.9")
-    endif()
-    if(NOT CLANG_TIDY_BIN)
-      find_program(CLANG_TIDY_BIN "clang_tidy")
-    endif()
-        message(STATUS ${CLANG_TIDY_BIN})
-    if(NOT CLANG_TIDY_BIN)
-        add_custom_target(clang-tidy
-            COMMAND ${CMAKE_COMMAND} -E echo_append "clang-tidy executable not found"
-            VERBATIM)
-    else()
-        message (STATUS "FOUND CLANG-TIDY")
-        set(CLANG_TIDY_COMMAND COMMAND ${CLANG_TIDY_BIN} ${ALL_CXX_SOURCE_FILES} -config='' -header-filter=\".*\\/ct\\/.*\" -- -std=c++11 -fopenmp ${CURRENT_INC_DIRS})
-            
-        add_custom_target(
-            clang-tidy
-            COMMAND ${CLANG_TIDY_COMMAND}
-            COMMENT "Launching clang-tidy"
-            WORKING_DIRECTORY ${CMAKE_PROJECT_DIR}
-            
-        )
-    endif() #CLANG_TIDY_BIN
-    
-endfunction()

ct_doc/doc/developer_info.dox

@@ -11,16 +11,12 @@ to align the development with ongoing activities.
 We support clang-format and provide a style template to automatically format the source code. 
 Please refer to the clang-format style sheet in the package root directory for our conventions. 
 
-Example command for running clang-tidy:
-\code
-$ catkin build --no-deps <package_name> -v --make-args clang-tidy 
-\endcode
-
-For clang-format it's just the same: 
+Example command for running clang-format:
 \code
 $ catkin build --no-deps <package_name> -v --make-args clang-format 
 \endcode
 
+
 \section Explicit Template Instantiation
 
 CT relies on explicit template instantiation, that means precompilation of the library for 

ct_doc/doc/installation.dox

@@ -85,14 +85,9 @@ The following dependencies and bindings are optional but can help to enhance the
 
  - MATLAB (for Matlab logging)
 
- - <a href="http://clang.llvm.org/extra/clang-tidy/">clang-tidy</a>, install via
- \code{.sh}
- $ sudo apt-get install clang-tidy-3.9
- \endcode
-
  - <a href="https://clang.llvm.org/docs/ClangFormat.html">clang-format</a>, install via
   \code{.sh}
- $ sudo apt-get install clang-format-3.9
+ $ sudo apt-get install clang-format
  \endcode