VM test runner rewrite #4088
VM test runner rewrite #4088
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
packages/tx/test/types.ts
Outdated
| pre: Record<string, AccountState> | ||
| post: Partial<Record<ForkName, PostReceipt[]>> | ||
| transaction: BlobTransaction | ||
| } |
There was a problem hiding this comment.
These types are added with the following commit message "Add types for vm state test data", so with "vm" in the text, while the types here are in "tx", so there seems to be something off.
There was a problem hiding this comment.
Yes, good point, they would have had to have been moved over to the vm package along with making getTests and other helpers in testLoader.ts available there too for use with the new runners. But we could leave that as a potential followup.
There was a problem hiding this comment.
Side note if we/you tackle later: these tx specific things should never make it over, there should definitely no unified runner, only a very very lightweight unified 20 line file loader (as outlined in the chat) helper function, which is completely independent of whatever VM or TX code and can therefore be placed in a generic place (testdata package).
This reverts commit 5c06661.
…to tape-to-vitest-refactor-vm-testrunners
am1r021
force-pushed
the
tape-to-vitest-refactor-vm-testrunners
branch
from
7592482 to
e39ed30
Compare
…ted and actual test executions
…to tape-to-vitest-refactor-vm-testrunners
…to tape-to-vitest-refactor-vm-testrunners
…thereumjs/ethereumjs-monorepo into tape-to-vitest-refactor-vm-testrunners
This change aims to modernize the vm test runners by switching over from using tape to vitest, refining the test file reader, and dropping any unused features or parameters of the current test runners.