Skip to content

tx: add eip-7594 peerdas blob transactions in osaka #3976

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 54 commits into from
May 29, 2025
Merged

tx: add eip-7594 peerdas blob transactions in osaka #3976

merged 54 commits into from
May 29, 2025

Conversation

g11tech
Copy link
Contributor

@g11tech g11tech commented Apr 14, 2025

PR for supporting peerdas blob transactions and engine api

Copy link

codecov bot commented Apr 18, 2025

Codecov Report

Attention: Patch coverage is 65.39924% with 91 lines in your changes missing coverage. Please review.

Project coverage is 79.36%. Comparing base (3076891) to head (cf60e44).
Report is 1 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

Flag Coverage Δ
block 84.33% <ø> (ø)
blockchain 89.32% <ø> (ø)
client 67.61% <65.64%> (-0.04%) ⬇️
common 97.50% <100.00%> (+<0.01%) ⬆️
devp2p 86.78% <ø> (ø)
evm 73.08% <100.00%> (ø)
mpt 90.36% <ø> (+0.66%) ⬆️
rlp ?
statemanager 69.06% <ø> (ø)
static 99.11% <ø> (ø)
tx 89.83% <87.20%> (-0.06%) ⬇️
util 88.69% <24.24%> (-0.57%) ⬇️
vm 55.31% <16.66%> (-0.19%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@holgerd77
Copy link
Member

And? Working? (so, the JS crypto version)

@g11tech
Copy link
Contributor Author

g11tech commented May 26, 2025

And? Working? (so, the JS crypto version)

we are having issues with js crypto version in the added getpayloadv5 test (as soon as we use new cell functionality for first time the api server starts responding with econreset) but it working with ckzg

debugging with @acolytec3

@holgerd77
Copy link
Member

Some disruption in the force trying to get the JS KZG stuff working, will cycle @paulmillr in here!

@paulmillr
Copy link
Member

I will need the test vectors which pass on c and fail on m-eth.

@g11tech
Copy link
Contributor Author

g11tech commented May 28, 2025

I will need the test vectors which pass on c and fail on m-eth.

funny enough it passes on node version 18 for microsigner (and fails on 20,22,23 with somehow the test rpc server starting to give ECONRESET after first use of the cell functionality in the test which is at L88 in test/rpc/engine/getPayloadV5.spec.ts)

@g11tech
Copy link
Contributor Author

g11tech commented May 28, 2025

so the test is:

npx vitest run test/rpc/engine/getPayloadV5.spec.ts

and in the latest commit you can switch between ckzg and microsigner kzg by commenting/uncommenting L740 in client/bin/utils.ts

@paulmillr
Copy link
Member

@g11tech ideally we’d just have a single test input which would fail so that I can add it into m-eth test vectors. That would be more reliable and won’t require setting up monorepo infra just for the test. That would also ensure the problem is unrelated to monorepo environment.

@jochem-brouwer
Copy link
Member

@paulmillr Sorry, should have updated, we found the problem: it is due to NodeJS imposing a Keep-Alive limit of 5 seconds since Node v19. Since Node v19 the tests fail. The specific test which was failing is fixed by bumping the keep alive limit 658c6ed

There are other tests failing but these are unrelated. So this is not on the micro-eth-signer side, it is rather Node imposing new fields in the HTTP headers which somehow (?) cause the tests to fail. (It might also be that micro-eth-signer is blocking a thread for a long time though, which causes the KeepAlive to fail)

@g11tech g11tech changed the title tx: add peerdas blob transactions support tx: add eip-7594 peerdas blob transactions May 29, 2025
@g11tech g11tech changed the title tx: add eip-7594 peerdas blob transactions tx: add eip-7594 peerdas blob transactions in osaka May 29, 2025
@g11tech
Copy link
Contributor Author

g11tech commented May 29, 2025

thanks @paulmillr @jochem-brouwer @acolytec3 @holgerd77 for your efforts and support 🚀 🚀

PR is ready for merge (and tested in kurtosis as well)

Copy link
Contributor

@acolytec3 acolytec3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@acolytec3 acolytec3 merged commit ad2fd6d into master May 29, 2025
39 of 40 checks passed
@acolytec3 acolytec3 deleted the peerdas branch May 29, 2025 10:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants