-
Notifications
You must be signed in to change notification settings - Fork 817
tx: add eip-7594 peerdas blob transactions in osaka #3976
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
And? Working? (so, the JS crypto version) |
we are having issues with js crypto version in the added getpayloadv5 test (as soon as we use new cell functionality for first time the api server starts responding with econreset) but it working with ckzg debugging with @acolytec3 |
Some disruption in the force trying to get the JS KZG stuff working, will cycle @paulmillr in here! |
I will need the test vectors which pass on c and fail on m-eth. |
funny enough it passes on node version 18 for microsigner (and fails on 20,22,23 with somehow the test rpc server starting to give ECONRESET after first use of the cell functionality in the test which is at L88 in |
so the test is:
and in the latest commit you can switch between ckzg and microsigner kzg by commenting/uncommenting L740 in |
@g11tech ideally we’d just have a single test input which would fail so that I can add it into m-eth test vectors. That would be more reliable and won’t require setting up monorepo infra just for the test. That would also ensure the problem is unrelated to monorepo environment. |
@paulmillr Sorry, should have updated, we found the problem: it is due to NodeJS imposing a Keep-Alive limit of 5 seconds since Node v19. Since Node v19 the tests fail. The specific test which was failing is fixed by bumping the keep alive limit 658c6ed There are other tests failing but these are unrelated. So this is not on the |
This reverts commit d0b0404.
thanks @paulmillr @jochem-brouwer @acolytec3 @holgerd77 for your efforts and support 🚀 🚀 PR is ready for merge (and tested in kurtosis as well) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
PR for supporting peerdas blob transactions and engine api