Skip to content

Typos fix #16064

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Typos fix #16064

wants to merge 1 commit into from

Conversation

MaxweLL22-22
Copy link

Fix: Corrected typos in source files

Changes

Corrected typo in /Changelog.md (Line 1604)

"wast" → "waste"

Corrected typo in /Changelog.md (Line 1834)

"compilability" → "compatibility"

Purpose

Improved code accuracy and professionalism by fixing typos.

Copy link

Thank you for your contribution to the Solidity compiler! A team member will follow up shortly.

If you haven't read our contributing guidelines and our review checklist before, please do it now, this makes the reviewing process and accepting your contribution smoother.

If you have any questions or need our help, feel free to post them in the PR or talk to us directly on the #solidity-dev channel on Matrix.

@@ -1601,7 +1601,7 @@ Language Features:

Compiler Features:
* ABI: Additional internal type info in the field ``internalType``.
* eWasm: Highly experimental eWasm output using ``--ewasm`` in the commandline interface or output selection of ``ewasm.wast`` in standard-json.
* eWasm: Highly experimental eWasm output using ``--ewasm`` in the commandline interface or output selection of ``ewasm.waste`` in standard-json.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This fix is wrong, it is not a typo. .wast is a file extension for WebAssembly Script Text: https://github.com/WebAssembly/spec/tree/main/interpreter#running-modules-or-scripts.

@@ -1831,7 +1831,7 @@ Bugfixes:
* SMTChecker: Fix crash related to statically-sized arrays.
* TypeChecker: Fix internal error and disallow index access on contracts and libraries.
* Yul: Properly detect name clashes with functions before their declaration.
* Yul: Take built-in functions into account in the compilability checker.
* Yul: Take built-in functions into account in the compatibility checker.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is also incorrect. The compilability checker is a component of the compiler that verifies whether all variables are reachable on the stack. See: #6063

@r0qs
Copy link
Member

r0qs commented May 23, 2025

I'm closing this PR since it doesn't fix anything.

@r0qs r0qs closed this May 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants