AssemblyItem asserts that it's not implicity constructed by instruction for swapn/dupn #16026
+4
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clonker
force-pushed
the
assert_swapn_dupn_in_assemblyitem
branch
from
b6b074b to
ab279e9
Compare
cameel
approved these changes
May 6, 2025
…ion for swapn/dupn
cameel
force-pushed
the
assert_swapn_dupn_in_assemblyitem
branch
from
ab279e9 to
78107e3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Otherwise this can lead to
AssemblyItems that have the instruction set but not the corresponding type.SWAPN/DUPNshould only ever be created by theAssemblyItem::swapNAssemblyItem::dupNhelper functions.