Skip to content

Language Server: Fix hover crashes on invalid parameters #15980

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 14, 2025

Conversation

henryhchchc
Copy link
Contributor

When textDocument/hover gets an out-of-range request, sourceNode will be a nullptr, which leads to a crash in toRange() (Line 64).

auto const [sourceNode, sourceOffset] = m_server.astNodeAndOffsetAtSourceLocation(sourceUnitName, lineColumn);
MarkdownBuilder markdown;
auto rangeToHighlight = toRange(sourceNode->location());

Copy link

github-actions bot commented Apr 4, 2025

Thank you for your contribution to the Solidity compiler! A team member will follow up shortly.

If you haven't read our contributing guidelines and our review checklist before, please do it now, this makes the reviewing process and accepting your contribution smoother.

If you have any questions or need our help, feel free to post them in the PR or talk to us directly on the #solidity-dev channel on Matrix.

When `textDocument/hover` gets an out-of-range request
@nikola-matic nikola-matic merged commit 08310eb into ethereum:develop Apr 14, 2025
74 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants