Replace yarn by pnpm and drop perpetual-pools external test #15067
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nable to resolve Hardhat dependencies
r0qs
changed the title
nikola-matic
approved these changes
Apr 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apparently,
yarncannot anymore correctly resolve hardhat dependencies: https://app.circleci.com/pipelines/github/ethereum/solidity/33914/workflows/5a5a125e-4fdf-4758-8262-1138eeaa6549/jobs/1532619?invite=true#step-108-14857_47. Switching topnpmseems to solve the issue.This PR also removes the perpetual-pools external tests since it seems inactive for around two years now: mycelium-ethereum/perpetual-pools-contracts@48264d7 and our current fork would require a significant amount of work to update
hardhatand other dependencies to work properly.We should consider add other active projects to the external tests, now using our python test suite instead of the old bash scripts.