Replace string comparison with empty() method in Parser

eeemmmmmm · clonker · commit e000f183b189 · 2025-07-03T17:16:36.000+02:00
diff --git a/libsolidity/parsing/Parser.cpp b/libsolidity/parsing/Parser.cpp
@@ -217,7 +217,7 @@ void Parser::parsePragmaVersion(SourceLocation const& _location, std::vector<Tok
 
 ASTPointer<StructuredDocumentation> Parser::parseStructuredDocumentation()
 {
-	if (m_scanner->currentCommentLiteral() != "")
+	if (!m_scanner->currentCommentLiteral().empty())
 	{
 		ASTNodeFactory nodeFactory{*this};
 		nodeFactory.setLocation(m_scanner->currentCommentLocation());
@@ -1445,7 +1445,7 @@ ASTPointer<Statement> Parser::parseStatement(bool _allowUnchecked)
 	RecursionGuard recursionGuard(*this);
 	ASTPointer<ASTString> docString;
 	ASTPointer<Statement> statement;
-	if (m_scanner->currentCommentLiteral() != "")
+	if (!m_scanner->currentCommentLiteral().empty())
 		docString = std::make_shared<ASTString>(m_scanner->currentCommentLiteral());
 	switch (m_scanner->currentToken())
 	{

Original file line number	Diff line number	Diff line change
`@@ -217,7 +217,7 @@ void Parser::parsePragmaVersion(SourceLocation const& _location, std::vector<Tok`
`217`	`217`
`218`	`218`	`ASTPointer<StructuredDocumentation> Parser::parseStructuredDocumentation()`
`219`	`219`	`{`
`220`		`- if (m_scanner->currentCommentLiteral() != "")`
	`220`	`+ if (!m_scanner->currentCommentLiteral().empty())`
`221`	`221`	`{`
`222`	`222`	`ASTNodeFactory nodeFactory{*this};`
`223`	`223`	`nodeFactory.setLocation(m_scanner->currentCommentLocation());`
`@@ -1445,7 +1445,7 @@ ASTPointer<Statement> Parser::parseStatement(bool _allowUnchecked)`
`1445`	`1445`	`RecursionGuard recursionGuard(*this);`
`1446`	`1446`	`ASTPointer<ASTString> docString;`
`1447`	`1447`	`ASTPointer<Statement> statement;`
`1448`		`- if (m_scanner->currentCommentLiteral() != "")`
	`1448`	`+ if (!m_scanner->currentCommentLiteral().empty())`
`1449`	`1449`	`docString = std::make_shared<ASTString>(m_scanner->currentCommentLiteral());`
`1450`	`1450`	`switch (m_scanner->currentToken())`
`1451`	`1451`	`{`