Replace string comparison with empty() method in DocStringParser

eeemmmmmm · clonker · commit b1953d22128d · 2025-07-03T17:16:36.000+02:00
diff --git a/libsolidity/parsing/DocStringParser.cpp b/libsolidity/parsing/DocStringParser.cpp
@@ -163,7 +163,7 @@ DocStringParser::iter DocStringParser::parseDocTag(iter _pos, iter _end, std::st
 {
 	// TODO: need to check for @(start of a tag) between here and the end of line
 	// for all cases.
-	if (!m_lastTag || _tag != "")
+	if (!m_lastTag || !_tag.empty())
 	{
 		if (_tag == "param")
 			return parseDocTagParam(_pos, _end);

Original file line number	Diff line number	Diff line change
`@@ -163,7 +163,7 @@ DocStringParser::iter DocStringParser::parseDocTag(iter _pos, iter _end, std::st`
`163`	`163`	`{`
`164`	`164`	`// TODO: need to check for @(start of a tag) between here and the end of line`
`165`	`165`	`// for all cases.`
`166`		`- if (!m_lastTag \|\| _tag != "")`
	`166`	`+ if (!m_lastTag \|\| !_tag.empty())`
`167`	`167`	`{`
`168`	`168`	`if (_tag == "param")`
`169`	`169`	`return parseDocTagParam(_pos, _end);`