eth/protocols/snap: add healing and syncing metrics #32258
Merged
+26
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
INFO [07-22|17:37:39.514] State sync phase is completed elapsed=1h55m11.733s |
|
| // Note: healing may be rerun in subsequent cycles to fill gaps between | ||
| // pivot states (e.g., if chain sync takes longer). | ||
| if !s.healStartTime.IsZero() { | ||
| stateHealTimeGauge.Inc(int64(time.Since(s.healStartTime))) |
There was a problem hiding this comment.
We can discuss it in the triage. I am not sure what kind of data is really important for us.
We have a few choices on table:
- Track the healing time for the first occurrence
- Track the cumulative healing time for all cycles
There was a problem hiding this comment.
Okay, I guess inc is the better way of doing it
There was a problem hiding this comment.
Maybe we should also track the chain sync time
There was a problem hiding this comment.
yeah, maybe another PR, i will merge it first
rjl493456442
approved these changes
Jul 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the heal time and snap sync time to grafana