core: exit prefetch just after block processed #31903
Closed
+2
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: jsvisa <delweng@gmail.com>
rjl493456442
requested changes
May 26, 2025
There was a problem hiding this comment.
I would prefer to keep it as now, reasons:
- the prefetcher will also do the state hashing to warm the trie node cache
- the prefetcher might be optimized a bit more in the future, (e.g., efficient trie node preloading) and the state hashing is performed after the block processing
- there is no big downside to let the prefetcher run a bit more
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As the tx prefetches are used to pre-warm the account/storage states, which will be used for the block processing. Currently we will exit the tx prefetch goroutines after the block has been processed + state validated, but the later should be omited, so try to stop the prefetches just after the block have been processed