-
Notifications
You must be signed in to change notification settings - Fork 20.9k
cmd/geth, cmd/utils: log prefunded account/key in ephemeral development mode #31898
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
… dev accounts with private keys
This comment was marked as outdated.
This comment was marked as outdated.
… and key, enhance dev account display
I'll take over this PR from here. |
This comment was marked as outdated.
This comment was marked as outdated.
note to self: while trying to wrap this, I ended up making a mistake that would have broken the use of custom keystore with ephemeral dev mode. I caught this before pushing, but it highlights that a test case would be useful because it's an edge case that I am only aware of because it was previously broken by accident and then fixed (in separate PRs) |
This comment was marked as outdated.
This comment was marked as outdated.
One other change this PR makes is that the default prefunded developer address for ephemeral dev mode is now constant instead of being randomly generated at client startup. It really simplifies the resulting code by being able to easily know, when printing the new dev-mode banner whether or not we're using a prefunded developer account (if we aren't ephemeral, it won't be used. if the keystore is overriden, it won't be used) |
other area for test coverage:
|
…larify the code that was broken.
My comments turned into a bit of a stream of consciousness. I'll summarize what's going on with this PR in its current (assumed final) state in the top-level comment on this PR. |
I like the idea of having a static private key |
ad48689
to
a8886f7
Compare
This PR modifies the disclaimer/banner that is printed when starting up Geth in dev mode:
Other change is that we now use a static prefunded dev account instead of generating a random one when instantiating a new dev mode chain.
This is an example of what the banner looks like:
closes #31796