trie: make deletion of Trie more readable when match shortNode #31889
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors the delete logic for
shortNode
in the MPT implementation to improve code readability and consistency with theinsert
function.Motivation
Previously, the code used:
However, at this point in the code,
matchlen
is always equal tolen(n.Key)
, so usingkey[:matchlen]
andkey[matchlen:]
is both clearer and stylistically consistent with theinsert
function. This change makes the code easier to read and maintain, and reduces potential confusion for future contributors.