eth/filters: fix TestInvalidGetLogsRequest #31877
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fjl
changed the title
fjl
reviewed
May 23, 2025
| // Reason: Cannot specify both BlockHash and FromBlock/ToBlock) | ||
| testCases := []FilterCriteria{ | ||
| 0: {BlockHash: &blockHash, FromBlock: big.NewInt(100)}, | ||
| 1: {BlockHash: &blockHash, ToBlock: big.NewInt(500)}, |
There was a problem hiding this comment.
I think these tests were just meant to check that FromBlock/ToBlock is mutually exclusive with BlockHash.
There was a problem hiding this comment.
but it does not actually return any error for these cases in the GetLogs (there is an if/else check)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Seems tests were actually returning
not founderror and test cases are actually not correct as implementation never returns err for those cases.This PR correctly populates the DB and adheres the fixes test cases