core, ethdb: introduce database sync function #31703
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oi |
fjl
changed the title
fjl
reviewed
Apr 29, 2025
MariusVanDerWijden
approved these changes
May 8, 2025
| @@ -144,7 +144,7 @@ func (l panicLogger) Fatalf(format string, args ...interface{}) { | |||
|
|
|||
| // New returns a wrapped pebble DB object. The namespace is the prefix that the | |||
| // metrics reporting should use for surfacing internal stats. | |||
| func New(file string, cache int, handles int, namespace string, readonly bool, ephemeral bool) (*Database, error) { | |||
| func New(file string, cache int, handles int, namespace string, readonly bool) (*Database, error) { | |||
There was a problem hiding this comment.
Should we introduce a pebble.Config struct here?
There was a problem hiding this comment.
Not sure. It's a bit complicated for external users to configure the Pebble by themselves?
There was a problem hiding this comment.
Anyway, it can be done in the following PR!
Dargon789
pushed a commit
to Dargon789/go-ethereum
that referenced
this pull request
May 27, 2025
This pull request introduces a SyncKeyValue function to the ethdb.KeyValueStore interface, providing the ability to forcibly flush all previous writes to disk. This functionality is critical for go-ethereum, which internally uses two independent database engines: a key-value store (such as Pebble, LevelDB, or memoryDB for testing) and a flat-file–based freezer. To ensure write-order consistency between these engines, the key-value store must be explicitly synced before writing to the freezer and vice versa. Fixes - ethereum#31405 - ethereum#29819
sduchesneau
pushed a commit
to streamingfast/go-ethereum
that referenced
this pull request
Jun 6, 2025
This pull request introduces a SyncKeyValue function to the ethdb.KeyValueStore interface, providing the ability to forcibly flush all previous writes to disk. This functionality is critical for go-ethereum, which internally uses two independent database engines: a key-value store (such as Pebble, LevelDB, or memoryDB for testing) and a flat-file–based freezer. To ensure write-order consistency between these engines, the key-value store must be explicitly synced before writing to the freezer and vice versa. Fixes - ethereum#31405 - ethereum#29819
sduchesneau
pushed a commit
to streamingfast/go-ethereum
that referenced
this pull request
Jun 6, 2025
core, ethdb: introduce database sync function (ethereum#31703)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces a SyncKeyValue function to the ethdb.KeyValueStore
interface, providing the ability to forcibly flush all previous writes to disk.
This functionality is critical for go-ethereum, which internally uses two independent
database engines: a key-value store (such as Pebble, LevelDB, or memoryDB for
testing) and a flat-file–based freezer. To ensure write-order consistency between
these engines, the key-value store must be explicitly synced before writing to the
freezer and vice versa.
Fixes