Skip to content

feat: add debug.setSyncTarget console command (#31375) #31665

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

feat: add debug.setSyncTarget console command (#31375) #31665

wants to merge 2 commits into from
+90 −29

Conversation

demoncoder-crypto
Copy link

No description provided.

@demoncoder-crypto demoncoder-crypto mentioned this pull request Apr 17, 2025
Open
@MariusVanDerWijden
Copy link
Member

Have you even tried this once?
It's not working like this...
I will push an update to this which makes it work

MariusVanDerWijden
MariusVanDerWijden reviewed Apr 23, 2025
View reviewed changes
internal/ethapi/api.go
log.Error("Could not get downloader")
}
// retry 20 times to retrieve the header from random peers
for range 20 {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not a big fan of this tbh, open for suggestions here

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you need the complete change here, please do let me know I am more than happy to work on it, Thanks for the reply .

@demoncoder-crypto
Copy link
Author

Have you even tried this once?
It's not working like this...
I will push an update to this which makes it work, @MariusVanDerWijden I have not tested it at all I just wanted to see if my given direction is correct, so I can iteratively fix and work upon the solution. I am sorry for the mess but thought rather than making a faulty implementation right I should ask for general guidance first and then proceed to make it work as this is my first time working with Ethereum.

@demoncoder-crypto
Copy link
Author

So any suggestions on how to proceed with this, if my track is right should I proceed to improve this implementation?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MariusVanDerWijden MariusVanDerWijden MariusVanDerWijden left review comments

@fjl fjl Awaiting requested review from fjl fjl is a code owner

@s1na s1na Awaiting requested review from s1na s1na is a code owner

@lightclient lightclient Awaiting requested review from lightclient lightclient is a code owner

@jwasinger jwasinger Awaiting requested review from jwasinger jwasinger is a code owner

@rjl493456442 rjl493456442 Awaiting requested review from rjl493456442 rjl493456442 is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

@MariusVanDerWijden MariusVanDerWijden

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@demoncoder-crypto @MariusVanDerWijden