core/txpool/legacypool: fix data race of txlookup access #31641
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The race detector flagged this in some automated tests I run against the simulated backend.
LegacyPool.Clear is only called by the simulated beacon chain so i'm not sure if this applies to anything other than the simulated backend. But other methods, like LegacyPool.SetGasTip, access pool.all while holding the pool lock, which could create a data race with LegacyPool.Add.