core: initialize history pruning in BlockChain #31636
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fjl
commented
Apr 14, 2025
| // PostMergeHistory sets the history pruning point to the merge activation block. | ||
| PostMergeHistory | ||
| // KeepPostMerge sets the history pruning point to the merge activation block. | ||
| KeepPostMerge | ||
| ) | ||
|
|
||
| func (m HistoryMode) IsValid() bool { |
There was a problem hiding this comment.
nitpick, i would prefer to rename it to Mode. Combined with the package name it's history.Mode
core/history/historymode.go
Outdated
| BlockNumber uint64 | ||
| BlockHash common.Hash | ||
| } | ||
|
|
||
| // HistoryPrunePoints contains the pre-defined history pruning cutoff blocks for known networks. | ||
| // PrunePointsins the pre-defined history pruning cutoff blocks for known networks. |
| if predefinedPoint == nil || freezerTail != predefinedPoint.BlockNumber { | ||
| log.Error("Chain history database is pruned with unknown configuration", "tail", freezerTail) | ||
| return fmt.Errorf("unexpected database tail") | ||
| } |
There was a problem hiding this comment.
I would prefer to have a warning log here, saying that the Geth is run with KeepAll but it was pruned previously
There was a problem hiding this comment.
It's something to consider, but for now, we really don't want people to use another pruning target block.
rjl493456442
previously approved these changes
Apr 15, 2025
sivaratrisrinivas
pushed a commit
to sivaratrisrinivas/go-ethereum
that referenced
this pull request
Apr 21, 2025
I added the history mode configuration in eth/ethconfig initially, since it seemed like the logical place. But it turns out we need access to the intended pruning setting at a deeper level, and it actually needs to be integrated with the blockchain startup procedure. With this change applied, if a node previously had its history pruned, and is subsequently restarted **without** the `--history.chain postmerge` flag, the `BlockChain` initialization code will now verify the freezer tail against the known pruning point of the predefined network and will restore pruning status. Note that this logic is quite restrictive, we allow non-zero tail only for known networks, and only for the specific pruning point that is defined.
0g-wh
pushed a commit
to 0glabs/0g-geth
that referenced
this pull request
Apr 22, 2025
I added the history mode configuration in eth/ethconfig initially, since it seemed like the logical place. But it turns out we need access to the intended pruning setting at a deeper level, and it actually needs to be integrated with the blockchain startup procedure. With this change applied, if a node previously had its history pruned, and is subsequently restarted **without** the `--history.chain postmerge` flag, the `BlockChain` initialization code will now verify the freezer tail against the known pruning point of the predefined network and will restore pruning status. Note that this logic is quite restrictive, we allow non-zero tail only for known networks, and only for the specific pruning point that is defined.
0g-wh
pushed a commit
to 0g-wh/0g-geth
that referenced
this pull request
May 8, 2025
I added the history mode configuration in eth/ethconfig initially, since it seemed like the logical place. But it turns out we need access to the intended pruning setting at a deeper level, and it actually needs to be integrated with the blockchain startup procedure. With this change applied, if a node previously had its history pruned, and is subsequently restarted **without** the `--history.chain postmerge` flag, the `BlockChain` initialization code will now verify the freezer tail against the known pruning point of the predefined network and will restore pruning status. Note that this logic is quite restrictive, we allow non-zero tail only for known networks, and only for the specific pruning point that is defined.
Rampex1
pushed a commit
to streamingfast/go-ethereum
that referenced
this pull request
May 15, 2025
I added the history mode configuration in eth/ethconfig initially, since it seemed like the logical place. But it turns out we need access to the intended pruning setting at a deeper level, and it actually needs to be integrated with the blockchain startup procedure. With this change applied, if a node previously had its history pruned, and is subsequently restarted **without** the `--history.chain postmerge` flag, the `BlockChain` initialization code will now verify the freezer tail against the known pruning point of the predefined network and will restore pruning status. Note that this logic is quite restrictive, we allow non-zero tail only for known networks, and only for the specific pruning point that is defined.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added the history mode configuration in eth/ethconfig initially, since it seemed like the logical place. But it turns out we need access to the intended pruning setting at a deeper level, and it actually needs to be integrated with the blockchain startup procedure.
With this change applied, if a node previously had its history pruned, and is subsequently restarted without the
--history.chain postmergeflag, theBlockChaininitialization code will now verify the freezer tail against the known pruning point of the predefined network and will restore pruning status. Note that this logic is quite restrictive, we allow non-zero tail only for known networks, and only for the specific pruning point that is defined.