Skip to content

eth: add logic to drop peers randomly when saturated #31476

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 27 commits into from
Apr 14, 2025
Merged
Show file tree
Hide file tree
Changes from 7 commits
Commits
Show all changes
27 commits
Select commit Hold shift + click to select a range
136d32d
p2p/connmanager: add connection manager to create some churn
cskiraly Mar 23, 2025
7a49bf0
p2p/connmanager: only drop from dialed peers
cskiraly Mar 24, 2025
91c1c30
p2p/connmanager: avoid dropping trusted peers
cskiraly Mar 24, 2025
75e4c26
p2p/connmanager: avoid dropping peers too early
cskiraly Mar 24, 2025
4635dac
p2p/connmanager: set meaningful defaults
cskiraly Mar 24, 2025
23cda63
p2p/peer: expose conn flags through getter functions
cskiraly Mar 25, 2025
ea8d05a
p2p/server: expose MaxInboundConns and MaxDialedConns
cskiraly Mar 25, 2025
e0b0189
eth/connmanager: move Connection Manager to package eth
cskiraly Mar 25, 2025
c41569d
eth/connmanager: use slices.DeleteFunc to filter in place
cskiraly Mar 25, 2025
61b26a9
eth/connman: fixup log levels
cskiraly Mar 25, 2025
628c5e5
eth/connmanager: get sync status
cskiraly Mar 25, 2025
cb5d672
eth/connmanager: no need to store srv
cskiraly Mar 25, 2025
301b396
eth/connmanager: monitor sync status
cskiraly Mar 26, 2025
77d634c
eth/connmanager: handle inbound and dialed peers separately
cskiraly Mar 26, 2025
d46ef40
fixing newlines
cskiraly Mar 28, 2025
8bb7f1e
eth/connmanager: randomize peer drop timers
cskiraly Mar 29, 2025
42d2c9b
eth: renaming Connection Manager to Dropper
cskiraly Apr 7, 2025
e9065ac
simplify rand usage
cskiraly Apr 10, 2025
5da26a9
eth/dropper: simplify cfg
cskiraly Apr 10, 2025
75c8ee1
eth/dropper: simplify code
cskiraly Apr 10, 2025
1647f51
eth/dropper: add metrics
cskiraly Apr 11, 2025
7a76bdd
eth/dropper: simplify sync status query
cskiraly Apr 11, 2025
4a69bf9
eth/dropper: fixing logs
cskiraly Apr 11, 2025
ff66b1c
eth/dropper: remove unused peerEvent channel
cskiraly Apr 11, 2025
2a9372e
eth/dropper: changing error code to DiscUselessPeer
cskiraly Apr 11, 2025
976e039
set doNotDropBefore to 10 minutes
cskiraly Apr 14, 2025
4961445
Update dropper.go
fjl Apr 14, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 4 additions & 7 deletions eth/backend.go
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,7 @@ type Ethereum struct {

handler *handler
discmix *enode.FairMix
connman *connManager
dropper *dropper

// DB interfaces
chainDb ethdb.Database // Block chain database
Expand Down Expand Up @@ -290,10 +290,7 @@ func New(stack *node.Node, config *ethconfig.Config) (*Ethereum, error) {
return nil, err
}

eth.connman = newConnManager(&connmanConfig{
maxDialPeers: eth.p2pServer.MaxDialedConns(),
maxInboundPeers: eth.p2pServer.MaxInboundConns(),
})
eth.dropper = newDropper(eth.p2pServer.MaxDialedConns(), eth.p2pServer.MaxInboundConns())

eth.miner = miner.New(eth, config.Miner, eth.engine)
eth.miner.SetExtra(makeExtraData(config.Miner.ExtraData))
Expand Down Expand Up @@ -406,7 +403,7 @@ func (s *Ethereum) Start() error {
s.handler.Start(s.p2pServer.MaxPeers)

// Start the connection manager
s.connman.Start(s.p2pServer, func() bool { return !s.Synced() })
s.dropper.Start(s.p2pServer, func() bool { return !s.Synced() })

// start log indexer
s.filterMaps.Start()
Expand Down Expand Up @@ -509,7 +506,7 @@ func (s *Ethereum) setupDiscovery() error {
func (s *Ethereum) Stop() error {
// Stop all the peer-related stuff first.
s.discmix.Close()
s.connman.Stop()
s.dropper.Stop()
s.handler.Stop()

// Then stop everything else.
Expand Down
254 changes: 0 additions & 254 deletions eth/connmanager.go

This file was deleted.

Loading