eth/catalyst: sanitize simulated beacon period to avoid overflowing time.Duration #31407
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…he time.Duration it will occupy
jwasinger
requested review from
MariusVanDerWijden,
lightclient and
fjl
as code owners
Co-authored-by: Marius van der Wijden <m.vanderwijden@live.de>
fjl
reviewed
Mar 18, 2025
jwasinger
commented
Mar 18, 2025
fjl
reviewed
Mar 19, 2025
MariusVanDerWijden
previously approved these changes
Mar 19, 2025
There was a problem hiding this comment.
Pull Request Overview
This pull request adds a check in the simulated beacon initialization to cap the period value, preventing an overflow when converting to time.Duration.
- Added an import for math.
- Introduced a maximum period check based on math.MaxInt64/time.Second with a corresponding log warning.
gballet
reviewed
Mar 23, 2025
gballet
reviewed
Mar 23, 2025
fjl
previously approved these changes
Apr 17, 2025
fjl
changed the title
time.Duration it will occupy
fjl
approved these changes
Apr 17, 2025
sivaratrisrinivas
pushed a commit
to sivaratrisrinivas/go-ethereum
that referenced
this pull request
Apr 21, 2025
…ime.Duration (ethereum#31407) closes ethereum#31401 --------- Co-authored-by: Marius van der Wijden <m.vanderwijden@live.de> Co-authored-by: Guillaume Ballet <3272758+gballet@users.noreply.github.com> Co-authored-by: Felix Lange <fjl@twurst.com>
0g-wh
pushed a commit
to 0glabs/0g-geth
that referenced
this pull request
Apr 22, 2025
…ime.Duration (ethereum#31407) closes ethereum#31401 --------- Co-authored-by: Marius van der Wijden <m.vanderwijden@live.de> Co-authored-by: Guillaume Ballet <3272758+gballet@users.noreply.github.com> Co-authored-by: Felix Lange <fjl@twurst.com>
0g-wh
pushed a commit
to 0g-wh/0g-geth
that referenced
this pull request
May 8, 2025
…ime.Duration (ethereum#31407) closes ethereum#31401 --------- Co-authored-by: Marius van der Wijden <m.vanderwijden@live.de> Co-authored-by: Guillaume Ballet <3272758+gballet@users.noreply.github.com> Co-authored-by: Felix Lange <fjl@twurst.com>
Rampex1
pushed a commit
to streamingfast/go-ethereum
that referenced
this pull request
May 15, 2025
…ime.Duration (ethereum#31407) closes ethereum#31401 --------- Co-authored-by: Marius van der Wijden <m.vanderwijden@live.de> Co-authored-by: Guillaume Ballet <3272758+gballet@users.noreply.github.com> Co-authored-by: Felix Lange <fjl@twurst.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #31401