Skip to content

common/math: delete some further dead code #30639

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 20, 2024
Merged

common/math: delete some further dead code #30639

merged 1 commit into from
Oct 20, 2024

Conversation

karalabe
Copy link
Member

No description provided.

@karalabe karalabe added this to the 1.14.12 milestone Oct 20, 2024
@karalabe karalabe merged commit 9015a05 into ethereum:master Oct 20, 2024
1 of 3 checks passed
@MariusVanDerWijden
Copy link
Member

This deletes math.Bytes() and math.FirstBitSet() which is probably used by some downstream projects, so we should add a note about that to the release notes

(don't disagree with the change btw, just think we should flag it)

holiman pushed a commit that referenced this pull request Nov 19, 2024
@karalabe @holiman
common/math: delete some further dead code (#30639)
997d122
zfy0701 pushed a commit to sentioxyz/go-ethereum that referenced this pull request Dec 3, 2024
@karalabe @zfy0701
common/math: delete some further dead code (ethereum#30639)
478e84c
@gzliudan gzliudan mentioned this pull request Dec 19, 2024
Merged
19 tasks
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Dec 19, 2024
@gzliudan
common/math: delete some further dead code (ethereum#30639)
0d0a04d
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Dec 21, 2024
@gzliudan
common/math: delete some further dead code (ethereum#30639)
97cd14b
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Dec 26, 2024
@gzliudan
common/math: delete some further dead code (ethereum#30639)
6989082
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Dec 28, 2024
@gzliudan
common/math: delete some further dead code (ethereum#30639)
156de2b
@Unique-Divine Unique-Divine mentioned this pull request Apr 16, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.14.12
Development

Successfully merging this pull request may close these issues.
2 participants
@karalabe @MariusVanDerWijden