Skip to content

feat(github): Add zkevm 60M, 90M, 120M #1655

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 26, 2025
Merged

feat(github): Add zkevm 60M, 90M, 120M #1655

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
9e69834
feat(github): Add zkevm 60M, 90M, 120M
marioevz May 26, 2025
704bdef
feat(github): Change zkevm feature to zkevm_36M
marioevz May 26, 2025
72e3930
docs: Changelog
marioevz May 26, 2025
bf8b9f8
whitelist
marioevz May 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 16 additions & 1 deletion .github/configs/feature.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,11 +11,26 @@ static:
evm-type: static
fill-params: --until=Prague --fill-static-tests ./tests/static
solc: 0.8.21
zkevm:
zkevm_36M:
evm-type: zkevm
fill-params: --from=Cancun --until=Prague --block-gas-limit 36000000 -m zkevm ./tests
solc: 0.8.21
feature_only: true
zkevm_60M:
evm-type: zkevm
fill-params: --from=Cancun --until=Prague --block-gas-limit 60000000 -m zkevm ./tests
solc: 0.8.21
feature_only: true
zkevm_90M:
evm-type: zkevm
fill-params: --from=Cancun --until=Prague --block-gas-limit 90000000 -m zkevm ./tests
solc: 0.8.21
feature_only: true
zkevm_120M:
evm-type: zkevm
fill-params: --from=Cancun --until=Prague --block-gas-limit 120000000 -m zkevm ./tests
solc: 0.8.21
feature_only: true
eip7692:
evm-type: eip7692
fill-params: --fork=EOFv1 ./tests/unscheduled
Expand Down
8 changes: 7 additions & 1 deletion docs/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,13 +8,19 @@ Test fixtures for use by clients are available for each release on the [Github r

### 💥 Breaking Change

### 💥 Important Change for `fill` Users
#### 💥 Important Change for `fill` Users

The output behavior of `fill` has changed ([#1608](https://github.com/ethereum/execution-spec-tests/pull/1608)):

- Before: `fill` wrote fixtures into the directory specified by the `--output` flag (default: `fixtures`). This could have many unintended consequences, including unexpected errors if old or invalid fixtures existed in the directory (for details see [#1030](https://github.com/ethereum/execution-spec-tests/issues/1030)).
- Now: `fill` will exit without filling any tests if the specified directory exists and is not-empty. This may be overridden by adding the `--clean` flag, which will first remove the specified directory.

#### Feature `zkevm` expanded to `zkevm_36M`, `zkevm_60M`, `zkevm_90M`, `zkevm_120M`

Renames `zkevm` to `zkevm_36M` and further expands the zkEVM features to run using 60M, 90M and 120M block gas limits in `fixtures_zkevm_36M.tar.gz`, `fixtures_zkevm_60M.tar.gz`, `fixtures_zkevm_90M.tar.gz` and `fixtures_zkevm_120M.tar.gz` respectively.

Users can select any of the artifacts depending on their testing needs for their provers.

### 🛠️ Framework

#### `fill`
Expand Down
2 changes: 2 additions & 0 deletions whitelist.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -578,6 +578,8 @@ parametrization
parametrizing
popen
prevrandao
prover
provers
pytestconfig
pytester
pytestmark
Expand Down
Loading