feat(tests): add type 4 transaction edge case test #1648
Merged
+56
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Requires ethereum/execution-specs#1255 before merging. |
marioevz
reviewed
May 26, 2025
spencer-tb
added
scope:tests
spencer-tb
approved these changes
May 28, 2025
marioevz
reviewed
May 28, 2025
LouisTsai-Csie
pushed a commit
to LouisTsai-Csie/execution-spec-tests
that referenced
this pull request
Jun 4, 2025
* add warm address test * change return opcode for stop * wrap CALL in CodeGasMeasure * make test future-proof
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🗒️ Description
Tests that when replacing the delegated contract of an account the previous contract shouldn't be kept in
accessed_addresses. We test this by making a CALL directly to it in the same transaction.Disclaimer: When filling the tests with the default tool (
ethereum-spec-evm-resolver) and executing that.jsonwith Geth or Reth these tests fail because the python execution spec doesn't behave in the same way that those clients do. For this I left a PR in the execution-specs repository.Of course, when filling directly with Geth t8n tool there is no problem when running the test.
🔗 Related Issues
✅ Checklist