feat(execute,tests): Implement get-blobs execute spec #1644
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…version refactor(tests): Blob type returns NetworkWrappedTransaction refactor(types): Move Blob to types refactor(types): NetworkWrappedTransaction uses Blob construct refactor(types): Return correct BlobAndProof
This reverts commit da371d2c45fdf448345168cb5ef2655b7ed05c90. feat(tests): Update 7594 test to include cell proofs
marioevz
added
scope:tests
marioevz
force-pushed
the
execute-blob-txs-tests
branch
from
d0a6be6 to
fe9f546
Compare
winsvega
reviewed
May 23, 2025
| tx = tx.with_signature_and_sender() | ||
| sent_txs.append(tx) | ||
| expected_hash = tx.hash | ||
| received_hash = eth_rpc.send_raw_transaction(tx.rlp()) |
There was a problem hiding this comment.
the transaction gets accepted without delay?
winsvega
reviewed
May 23, 2025
| versioned_hashes[versioned_hash] = BlobAndProof(blob=blob.data, proof=blob.kzg_proof) | ||
| elif blob.kzg_cell_proofs is not None: | ||
| versioned_hashes[versioned_hash] = BlobAndProof( | ||
| blob=blob.data, proofs=blob.kzg_cell_proofs |
There was a problem hiding this comment.
there can be many proofs? easy to make typo
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🗒️ Description
Adds
get_blobsmarked tests to execute that send blobs to a running client and verify the blob commitments usingengine_getBlobsVXendpoint.The tests can only be run using execute and cannot be used to generate fixtures using
fill, contrary to the rest of the specs which normally can do both operations.Test
tests/osaka/eip7594_peerdas/test_get_blobs.pyis added to make a sanity check of the blob endpoints for clients, but should be considered incomplete and a follow up PR should increase coverage by adding meaningful tests that contain proper kzg cell proofs.Note: The PR contains commits separated by functionality and could be merged using "Rebase and Merge".
🔗 Related Issues
None
✅ Checklist