-
Notifications
You must be signed in to change notification settings - Fork 153
zkevm: add remaining precompiles #1581
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
63ae656
to
d732c83
Compare
7376d45
to
100a25e
Compare
d732c83
to
1ff3fa6
Compare
100a25e
to
97de8f5
Compare
chfast
reviewed
May 16, 2025
8aa3517
to
dcebcf9
Compare
jsign
commented
May 16, 2025
jsign
commented
May 16, 2025
jsign
commented
May 16, 2025
774fab7
to
d52d458
Compare
@chfast, I applied your suggestions if you'd like to take another look. |
cbed263
to
16f5eae
Compare
Signed-off-by: Ignacio Hagopian <jsign.uy@gmail.com>
Signed-off-by: Ignacio Hagopian <jsign.uy@gmail.com>
Signed-off-by: Ignacio Hagopian <jsign.uy@gmail.com>
Signed-off-by: Ignacio Hagopian <jsign.uy@gmail.com>
Signed-off-by: Ignacio Hagopian <jsign.uy@gmail.com>
Signed-off-by: Ignacio Hagopian <jsign.uy@gmail.com>
Signed-off-by: Ignacio Hagopian <jsign.uy@gmail.com>
Signed-off-by: Ignacio Hagopian <jsign.uy@gmail.com>
Signed-off-by: Ignacio Hagopian <jsign.uy@gmail.com>
Signed-off-by: Ignacio Hagopian <jsign.uy@gmail.com>
Signed-off-by: Ignacio Hagopian <jsign.uy@gmail.com>
Signed-off-by: Ignacio Hagopian <jsign.uy@gmail.com>
Signed-off-by: Ignacio Hagopian <jsign.uy@gmail.com>
Signed-off-by: Ignacio Hagopian <jsign.uy@gmail.com>
16f5eae
to
d9bd7a5
Compare
chfast
approved these changes
May 21, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left two questions/comments I'd like to see address. But overall looks good to me.
Signed-off-by: Ignacio Hagopian <jsign.uy@gmail.com>
chfast
reviewed
May 21, 2025
Signed-off-by: Ignacio Hagopian <jsign.uy@gmail.com>
chfast
approved these changes
May 21, 2025
raxhvl
approved these changes
May 21, 2025
codeofcarson
pushed a commit
to codeofcarson/execution-spec-tests
that referenced
this pull request
Jul 1, 2025
* zkevm: more precompiles Signed-off-by: Ignacio Hagopian <jsign.uy@gmail.com> * improve params format Signed-off-by: Ignacio Hagopian <jsign.uy@gmail.com> * improve parameters Signed-off-by: Ignacio Hagopian <jsign.uy@gmail.com> * add bls12_g1msm Signed-off-by: Ignacio Hagopian <jsign.uy@gmail.com> * add bls12_g2msm Signed-off-by: Ignacio Hagopian <jsign.uy@gmail.com> * add blas12 pairing check Signed-off-by: Ignacio Hagopian <jsign.uy@gmail.com> * add bls_map tests Signed-off-by: Ignacio Hagopian <jsign.uy@gmail.com> * rebase & format Signed-off-by: Ignacio Hagopian <jsign.uy@gmail.com> * remove input length parameter Signed-off-by: Ignacio Hagopian <jsign.uy@gmail.com> * use bls12381 precompile addresses from spec and simplify parameter Signed-off-by: Ignacio Hagopian <jsign.uy@gmail.com> * make the linter happy Signed-off-by: Ignacio Hagopian <jsign.uy@gmail.com> * use symbolic parameters for bls12381 precompiles Signed-off-by: Ignacio Hagopian <jsign.uy@gmail.com> * lints Signed-off-by: Ignacio Hagopian <jsign.uy@gmail.com> * linter Signed-off-by: Ignacio Hagopian <jsign.uy@gmail.com> * add slow marker Signed-off-by: Ignacio Hagopian <jsign.uy@gmail.com> * rebase fixes Signed-off-by: Ignacio Hagopian <jsign.uy@gmail.com> * reuse some constants and precompile inputs * comments and fixes Signed-off-by: Ignacio Hagopian <jsign.uy@gmail.com> * clarify comment Signed-off-by: Ignacio Hagopian <jsign.uy@gmail.com> --------- Signed-off-by: Ignacio Hagopian <jsign.uy@gmail.com> Co-authored-by: Paweł Bylica <pawel@ethereum.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds coverage for all remaining precompiles:
I created a generic setup, so adding other precompile cases (if anyone thinks other inputs create even worse-case scenarios) is very simple.
I ran this in the SP1 for counting cycles: