-
Notifications
You must be signed in to change notification settings - Fork 153
Add optional field to exclude including postState #1578
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Ignacio Hagopian <jsign.uy@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some comments, thanks!
Co-authored-by: Mario Vega <marioevz@gmail.com>
Signed-off-by: Ignacio Hagopian <jsign.uy@gmail.com>
@marioevz is this mergable? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some last minute comments, thanks!
Co-authored-by: Mario Vega <marioevz@gmail.com>
Co-authored-by: Mario Vega <marioevz@gmail.com>
Signed-off-by: Ignacio Hagopian <jsign.uy@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
…reum#1578) * add optional field to exclude including postState Signed-off-by: Ignacio Hagopian <jsign.uy@gmail.com> * Update src/ethereum_test_specs/blockchain.py Co-authored-by: Mario Vega <marioevz@gmail.com> * switch to not including postState field Signed-off-by: Ignacio Hagopian <jsign.uy@gmail.com> * lints Signed-off-by: Ignacio Hagopian <jsign.uy@gmail.com> * Update src/ethereum_test_specs/blockchain.py Co-authored-by: Mario Vega <marioevz@gmail.com> * Update src/ethereum_test_specs/blockchain.py Co-authored-by: Mario Vega <marioevz@gmail.com> * feedback fixes Signed-off-by: Ignacio Hagopian <jsign.uy@gmail.com> --------- Signed-off-by: Ignacio Hagopian <jsign.uy@gmail.com> Co-authored-by: Mario Vega <marioevz@gmail.com>
…reum#1578) * add optional field to exclude including postState Signed-off-by: Ignacio Hagopian <jsign.uy@gmail.com> * Update src/ethereum_test_specs/blockchain.py Co-authored-by: Mario Vega <marioevz@gmail.com> * switch to not including postState field Signed-off-by: Ignacio Hagopian <jsign.uy@gmail.com> * lints Signed-off-by: Ignacio Hagopian <jsign.uy@gmail.com> * Update src/ethereum_test_specs/blockchain.py Co-authored-by: Mario Vega <marioevz@gmail.com> * Update src/ethereum_test_specs/blockchain.py Co-authored-by: Mario Vega <marioevz@gmail.com> * feedback fixes Signed-off-by: Ignacio Hagopian <jsign.uy@gmail.com> --------- Signed-off-by: Ignacio Hagopian <jsign.uy@gmail.com> Co-authored-by: Mario Vega <marioevz@gmail.com>
This PR is a requirement for #1575.