Skip to content

Add optional field to exclude including postState #1578

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
May 13, 2025

Conversation

jsign
Copy link
Collaborator

@jsign jsign commented May 8, 2025

This PR is a requirement for #1575.

Signed-off-by: Ignacio Hagopian <jsign.uy@gmail.com>
@jsign jsign marked this pull request as ready for review May 8, 2025 16:31
@jsign jsign requested a review from marioevz May 8, 2025 16:32
Copy link
Member

@marioevz marioevz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some comments, thanks!

jsign and others added 2 commits May 9, 2025 12:44
Co-authored-by: Mario Vega <marioevz@gmail.com>
Signed-off-by: Ignacio Hagopian <jsign.uy@gmail.com>
@jsign jsign requested a review from marioevz May 9, 2025 17:49
Signed-off-by: Ignacio Hagopian <jsign.uy@gmail.com>
@jsign
Copy link
Collaborator Author

jsign commented May 12, 2025

@marioevz is this mergable?

Copy link
Member

@marioevz marioevz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some last minute comments, thanks!

jsign and others added 3 commits May 13, 2025 13:15
Co-authored-by: Mario Vega <marioevz@gmail.com>
Co-authored-by: Mario Vega <marioevz@gmail.com>
Signed-off-by: Ignacio Hagopian <jsign.uy@gmail.com>
Copy link
Member

@marioevz marioevz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@marioevz marioevz merged commit 0e1dd2c into main May 13, 2025
21 checks passed
@marioevz marioevz deleted the jsign-optional-poststate branch May 13, 2025 16:56
felix314159 pushed a commit to felix314159/execution-spec-tests that referenced this pull request May 16, 2025
…reum#1578)

* add optional field to exclude including postState

Signed-off-by: Ignacio Hagopian <jsign.uy@gmail.com>

* Update src/ethereum_test_specs/blockchain.py

Co-authored-by: Mario Vega <marioevz@gmail.com>

* switch to not including postState field

Signed-off-by: Ignacio Hagopian <jsign.uy@gmail.com>

* lints

Signed-off-by: Ignacio Hagopian <jsign.uy@gmail.com>

* Update src/ethereum_test_specs/blockchain.py

Co-authored-by: Mario Vega <marioevz@gmail.com>

* Update src/ethereum_test_specs/blockchain.py

Co-authored-by: Mario Vega <marioevz@gmail.com>

* feedback fixes

Signed-off-by: Ignacio Hagopian <jsign.uy@gmail.com>

---------

Signed-off-by: Ignacio Hagopian <jsign.uy@gmail.com>
Co-authored-by: Mario Vega <marioevz@gmail.com>
codeofcarson pushed a commit to codeofcarson/execution-spec-tests that referenced this pull request Jul 1, 2025
…reum#1578)

* add optional field to exclude including postState

Signed-off-by: Ignacio Hagopian <jsign.uy@gmail.com>

* Update src/ethereum_test_specs/blockchain.py

Co-authored-by: Mario Vega <marioevz@gmail.com>

* switch to not including postState field

Signed-off-by: Ignacio Hagopian <jsign.uy@gmail.com>

* lints

Signed-off-by: Ignacio Hagopian <jsign.uy@gmail.com>

* Update src/ethereum_test_specs/blockchain.py

Co-authored-by: Mario Vega <marioevz@gmail.com>

* Update src/ethereum_test_specs/blockchain.py

Co-authored-by: Mario Vega <marioevz@gmail.com>

* feedback fixes

Signed-off-by: Ignacio Hagopian <jsign.uy@gmail.com>

---------

Signed-off-by: Ignacio Hagopian <jsign.uy@gmail.com>
Co-authored-by: Mario Vega <marioevz@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants