Skip to content

fix(tests): Fix precompile warmup tests on python 3.10 #1518

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 1, 2025

Conversation

marioevz
Copy link
Member

πŸ—’οΈ Description

Fixes an issue introduced in #1495 when using int.from_bytes without the byteorder keyword argument on python 3.10.

πŸ”— Related Issues

None

βœ… Checklist

  • All: Set appropriate labels for the changes.
  • All: Considered squashing commits to improve commit history.
  • All: Added an entry to CHANGELOG.md.
  • All: Considered updating the online docs in the ./docs/ directory.

@marioevz marioevz added the type:bug Something isn't working label Apr 30, 2025
@marioevz marioevz force-pushed the fix-precompile-warmup-tests-on-python-3.10 branch from 333a42e to afaaa2c Compare April 30, 2025 23:10
Copy link
Contributor

@spencer-tb spencer-tb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! cc @felix314159

@spencer-tb spencer-tb merged commit a740709 into main May 1, 2025
21 of 22 checks passed
@spencer-tb spencer-tb deleted the fix-precompile-warmup-tests-on-python-3.10 branch May 1, 2025 10:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants