-
Notifications
You must be signed in to change notification settings - Fork 201
Add blob schedule example to config/spec api #529
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
rolfyone
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
jimmygchen
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks!
|
How others client feel if the BPO entries return as descending sorted? In our current implementation, we sort the list while deserialize the config file, so we don't need to sort it every time the function called. I knew it won't cause much computation overhead for sorting few items, but the function will be often called while it is unnecessary redundant operation. Sorry for the late comment, everyone |
Currently
Does that mean if someone passes in the config, would we error if it's not sorted? Could open a follow-up PR / issue for more discussion, the main goal of this PR was to have a common format and not return a stringified array for example which would have been alternative format we could use |
I believe clients should be able to handle regardless of what order is |
Relevant spec ethereum/consensus-specs#4277 and ethereum/beacon-APIs#529 Implement EIP-7892 as laid out in v1.6.0-alpha.0 for fusaka devnet-0. Any open spec PR which is not within the scope of devnet-0 will be implemented in a follow up PR --------- Co-authored-by: Nico Flaig <nflaig@protonmail.com>
To accommodate ethereum/consensus-specs#4277 and clarify format we expect to be returned from
/eth/v1/config/specapi.