Skip to content

Conversation

@0x00101010
Copy link
Contributor

No description provided.

items:
$ref: "#/Deneb/BlobSidecar"
minItems: 0
maxItems: 48 # placeholder, depending on the final value we chose and BPO schedule
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm I feel that we should just use a really high value here instead. Let's discuss this first.

Suggested change
maxItems: 48 # placeholder, depending on the final value we chose and BPO schedule
maxItems: 4096 # MAX_BLOB_COMMITMENTS_PER_BLOCK

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 on setting it high enough that we don't ever need to change it anymore

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there was some discussion in #488 on this previously, I am generally in favor of using sane list limits but since blob limit increase will be effectively decoupled from (named) forks with EIP-7892 I also think it's best to use 4096 now

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 for 4096

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems like we have enough consensus here, updated

KZGCommitmentInclusionProof
LMD
fulu
BPO
Copy link
Member

@nflaig nflaig May 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this can be removed, the word was previously in comment for maxItems but removed in 6b4153b

@nalepae
Copy link
Contributor

nalepae commented May 19, 2025

Currently, this beacon API returns blob sidecars, including:

  • the blob index,
  • the blob,
  • the blob KZG commitment,
  • the KZG proof,
  • the signed block header, and
  • the KZG commitment inclusion proof.

It seems main users of the getBlobSidecars endpoint (L2s) mainly need the blob, and not all the other fields available in the blob sidecar.

Proposal: What about creating a new beacon API endpoint getBlob (and deprecating this one), returning only the blob?

Initial Discord thread

@nflaig nflaig mentioned this pull request Jul 26, 2025
@nflaig
Copy link
Member

nflaig commented Jul 28, 2025

Closing this PR in favor of #546

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants