-
Notifications
You must be signed in to change notification settings - Fork 201
[EIP-7594] Add new getBlobSidecars spec #524
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
types/fulu/blob_sidecar.yaml
Outdated
| items: | ||
| $ref: "#/Deneb/BlobSidecar" | ||
| minItems: 0 | ||
| maxItems: 48 # placeholder, depending on the final value we chose and BPO schedule |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm I feel that we should just use a really high value here instead. Let's discuss this first.
| maxItems: 48 # placeholder, depending on the final value we chose and BPO schedule | |
| maxItems: 4096 # MAX_BLOB_COMMITMENTS_PER_BLOCK |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 on setting it high enough that we don't ever need to change it anymore
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
there was some discussion in #488 on this previously, I am generally in favor of using sane list limits but since blob limit increase will be effectively decoupled from (named) forks with EIP-7892 I also think it's best to use 4096 now
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 for 4096
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
seems like we have enough consensus here, updated
f954bd7 to
6b4153b
Compare
| KZGCommitmentInclusionProof | ||
| LMD | ||
| fulu | ||
| BPO |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this can be removed, the word was previously in comment for maxItems but removed in 6b4153b
|
Currently, this beacon API returns blob sidecars, including:
It seems main users of the Proposal: What about creating a new beacon API endpoint |
|
Closing this PR in favor of #546 |
No description provided.