Clarify handling of empty arrays for ids/statuses in validators api #518
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pawanjay176
approved these changes
Apr 1, 2025
pawanjay176
left a comment
pawanjay176
left a comment
There was a problem hiding this comment.
I'm good with this too.
Just to be clear, this isn't the current behaviour in lighthouse. We return a 404 if the list is empty so this will require changes on our side.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar #453, clarifies handling of empty arrays, ie. if the value is
[]then no filtering should be applied and all validators should be returned. Since this caused interop issues just recently, I think it's worth clarifying this behavior on the spec.cc @james-prysm @pawanjay176 are you fine with the described behavior?