-
Notifications
You must be signed in to change notification settings - Fork 201
PeerDAS - cell proof computation changes #516
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 10 commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
28bb9fb
Add fulu related changes
0x00101010 830696c
Update based on comment
0x00101010 75d0336
Update based on discussions
0x00101010 a323f9f
Fix validation errors
0x00101010 24ac5cf
Update based on comment
0x00101010 c5ccb8b
Add back execution payload version bump related changes
0x00101010 ca2af3f
Remove formatting related changes
0x00101010 2b314d5
update based on comments
0x00101010 937383b
Remove unnecessary new types
0x00101010 1eda435
Remove unnecessary new types
0x00101010 0923d3c
update based on comment
0x00101010 9fd03a4
Add Fulu into wordlist to pass spellcheck
0x00101010 a9134b6
Add fulu to version enum in all api files
0x00101010 19b8630
Add missing api return
0x00101010 388af88
Resolve merge conflicts
nflaig File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,33 @@ | ||
| Fulu: | ||
| KZGProofs: | ||
| type: array | ||
| items: | ||
| $ref: "../primitive.yaml#/KZGProof" | ||
| minItems: 0 | ||
| maxItems: 33554432 # FIELD_ELEMENTS_PER_EXT_BLOB * MAX_BLOB_COMMITMENTS_PER_BLOCK | ||
|
|
||
| BlockContents: | ||
| type: object | ||
| description: "The required object for block production according to the Fulu CL spec." | ||
| required: [block, kzg_proofs, blobs] | ||
| properties: | ||
| block: | ||
| $ref: "../electra/block.yaml#/Electra/BeaconBlock" | ||
| kzg_proofs: | ||
| description: "Cell proofs of the blobs as defined in EIP-7594" | ||
| $ref: "#/Fulu/KZGProofs" | ||
| blobs: | ||
| $ref: "../deneb/block_contents.yaml#/Deneb/Blobs" | ||
|
|
||
| SignedBlockContents: | ||
| type: object | ||
| description: "The required signed components of block production according to the Fulu CL spec." | ||
| required: [signed_block, kzg_proofs, blobs] | ||
| properties: | ||
| signed_block: | ||
| $ref: "../electra/block.yaml#/Electra/SignedBeaconBlock" | ||
| kzg_proofs: | ||
| description: "Cell proofs of the blobs as defined in EIP-7594" | ||
| $ref: "#/Fulu/KZGProofs" | ||
| blobs: | ||
| $ref: "../deneb/block_contents.yaml#/Deneb/Blobs" |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we also need a
Fulu.BlobSidecarsfor thegetBlobSidecarsendpoint? Could be in a separate PR though.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, since max blob number is not determined, prefer to do it later
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Blob count is not the only thing that changes - each blob sidecar has a KzgProof field that should be changed to plurals with cell proofs. I reckon we could set a high but realistic blob count for the current PeerDAS, to avoid having to update this endpoint on every BPO hard fork?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cool, will update it tomorrow with other changes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
or we could deprecate the current one and at a new
getDataColumnSidecars? I feel like this is something consumers should give feedback on before doing something, afaik, L2 clients use those apisThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we'd probably want
getBlobsSidecarV2for blob consumers (L2s).DataColumnSidecarsis unlikely useful to end users - it's a CL-specific structure used for sample distribution and requires extra effort to convert into blobs, which L2 users are unlikely interested in. There could be use cases I'm missing though.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
how would a CL be able to reconstruct the blob if it's not a supernode? and is there any reason why we need a v2 api, the current api is fork-aware so can change the type if required
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's kick off the discussion on getBlobsSidecar/V2 api, let's do it in a separate PR to speed up merging this one