Skip to content

Conversation

@tersec
Copy link
Contributor

@tersec tersec commented Oct 30, 2024

Implements the agreed-upon outcome of the discussion in that call.

nflaig
nflaig previously approved these changes Oct 31, 2024
@mcdee
Copy link
Contributor

mcdee commented Oct 31, 2024

I think that this remains unclear, specifically around if the value includes slashing rewards to the proposer or not.

@rolfyone
Copy link
Contributor

I think that this remains unclear, specifically around if the value includes slashing rewards to the proposer or not.

part of proposer reward is explicitly the reward from inclusion of slashings, im not sure how we make it clearer unless we link to the spec...

@ensi321
Copy link
Contributor

ensi321 commented Oct 31, 2024

I think that this remains unclear, specifically around if the value includes slashing rewards to the proposer or not.

part of proposer reward is explicitly the reward from inclusion of slashings, im not sure how we make it clearer unless we link to the spec...

Agreed. Do we want to be explicit to the point saying Eth-Consensus-Block-Value = BlockRewards.total?

@mcdee
Copy link
Contributor

mcdee commented Nov 1, 2024

I think that stating explicitly that the rewards value is the sum of values the proposer rewards from attestations, sync committees and slashings included in the proposal would provide clarity on exactly what is and is not included.

@rolfyone
Copy link
Contributor

@tersec if we can address @mcdee comment we can merge..

@tersec
Copy link
Contributor Author

tersec commented Jan 5, 2025

@tersec if we can address @mcdee comment we can merge..

Done

Copy link
Member

@nflaig nflaig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rolfyone rolfyone merged commit aa1be25 into ethereum:master Jan 12, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants