Removed default builder boost #438
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removed "default" boost wording where the default value should be a fixed to 100 on clients as this has been changed to 90 on multiple clients.
2 tasks
Contributor
|
We can't just remove the default, it's already part of the released spec and it's possible that validator clients are sending in requests without this value and expecting it to be 100. Given that at this point there are client releases that have altered this value I think the best bet would be to state that if the parameter is not supplied then it defaults to whatever value is configured in the beacon node. Although that doesn't adhere to the spec as-is, and so is still a spec change, I think it is the closest that we will get when taking reality into account. |
Contributor
|
Given that we're just removing the 'default' term, this PR seems reasonable in description? |
rolfyone
approved these changes
Sep 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed "default" boost wording where the default value should be a fixed to 100 on clients as this has been changed to 90 on multiple clients.