Skip to content

go: Update op-geth to v1.101507.0, based on geth v1.15.7 #15587

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from

Conversation

sebastianst
Copy link
Member

@sebastianst sebastianst commented Apr 28, 2025

Description

Updates op-geth to v1.101507.0, based on geth v1.15.7 (ethereum-optimism/op-geth#571).

It also updates Go to 1.23 (toolchain pinned to 1.23.8), also in Docker and CI etc.

The majority of the reported large diff comes from f2c9300 which updates a Cannon compat report. It has been verified by @Inphi and doesn't need a review. The remaining diff is quite small and is mostly just updates to bump the Go version and a few adaptions to new APIs, notably, using tx.From() to directly get a deposit tx's from address.

There's a small group of failing tests TestSystem4844E2E_{Calldata,{Single,Multi}Blob} that seem to have been caused by this(ethereum/go-ethereum#31638) upstream change, but these tests seem to have been fixed again by ethereum/go-ethereum#31638 which got in somewhere between geth v1.15.{8...10}. Since we probably want to merge the 1.15.10 (or even 1.15.11) changes right away, I suggest we don't try to fix the test in this PR, since the fix is just moving the geth version forward.

Metadata

Closes ethereum-optimism/op-geth#559

@sebastianst sebastianst requested a review from a team as a code owner April 28, 2025 13:36
@sebastianst sebastianst requested a review from a user April 28, 2025 13:36
Copy link

wiz-inc-a178a98b5d bot commented Apr 28, 2025

Wiz Scan Summary

Scanner Findings
Vulnerability Finding Vulnerabilities 1 Medium
Data Finding Sensitive Data
Secret Finding Secrets
IaC Misconfiguration IaC Misconfigurations 2 High 2 Low
Total 2 High 1 Medium 2 Low

View scan details in Wiz

To detect these findings earlier in the dev lifecycle, try using Wiz Code VS Code Extension.

Copy link

codecov bot commented Apr 28, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.21%. Comparing base (4c68444) to head (7320a84).
Report is 9 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff              @@
##           develop   #15587       +/-   ##
============================================
+ Coverage    46.82%   81.21%   +34.38%     
============================================
  Files         1336      161     -1175     
  Lines       107829     8756    -99073     
============================================
- Hits         50495     7111    -43384     
+ Misses       53728     1512    -52216     
+ Partials      3606      133     -3473     
Flag Coverage Δ
cannon-go-tests-64 65.37% <ø> (-1.96%) ⬇️
contracts-bedrock-tests 96.06% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 1183 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@sebastianst sebastianst moved this to In Review in Protocol Team May 13, 2025
@sebastianst sebastianst added the M-do-not-merge Meta: Do not merge label May 13, 2025
Copy link
Contributor

@geoknee geoknee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I only reviewed 42c7d62. Noting failing tests but that we have a path forward which does not require them to pass just now.

@sebastianst sebastianst added the H-interop Hardfork: change planned for interop upgrade label May 13, 2025
@sebastianst
Copy link
Member Author

Contained in #15829

@github-project-automation github-project-automation bot moved this from In Review to Done in Protocol Team May 15, 2025
@sebastianst sebastianst deleted the seb/geth-v1.15.7 branch May 21, 2025 12:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
H-interop Hardfork: change planned for interop upgrade M-do-not-merge Meta: Do not merge
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Merge upstream geth/v1.15.{4,5,6,7}
3 participants