-
Notifications
You must be signed in to change notification settings - Fork 3.6k
go: Update op-geth to v1.101507.0, based on geth v1.15.7 #15587
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Wiz Scan Summary
To detect these findings earlier in the dev lifecycle, try using Wiz Code VS Code Extension. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #15587 +/- ##
============================================
+ Coverage 46.82% 81.21% +34.38%
============================================
Files 1336 161 -1175
Lines 107829 8756 -99073
============================================
- Hits 50495 7111 -43384
+ Misses 53728 1512 -52216
+ Partials 3606 133 -3473
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
772e220
to
c349c03
Compare
c349c03
to
491d25f
Compare
284286e
to
8f7bde7
Compare
8f7bde7
to
103b5c4
Compare
03f95d2
to
f2c9300
Compare
7320a84
to
09aa567
Compare
09aa567
to
2bdaa8c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I only reviewed 42c7d62. Noting failing tests but that we have a path forward which does not require them to pass just now.
Contained in #15829 |
Description
Updates op-geth to v1.101507.0, based on geth v1.15.7 (ethereum-optimism/op-geth#571).
It also updates Go to 1.23 (toolchain pinned to 1.23.8), also in Docker and CI etc.
The majority of the reported large diff comes from f2c9300 which updates a Cannon compat report. It has been verified by @Inphi and doesn't need a review. The remaining diff is quite small and is mostly just updates to bump the Go version and a few adaptions to new APIs, notably, using
tx.From()
to directly get a deposit tx's from address.There's a small group of failing tests
TestSystem4844E2E_{Calldata,{Single,Multi}Blob}
that seem to have been caused by this(ethereum/go-ethereum#31638) upstream change, but these tests seem to have been fixed again by ethereum/go-ethereum#31638 which got in somewhere between geth v1.15.{8...10}. Since we probably want to merge the 1.15.10 (or even 1.15.11) changes right away, I suggest we don't try to fix the test in this PR, since the fix is just moving the geth version forward.Metadata
Closes ethereum-optimism/op-geth#559