feat: Exit Button #6763
Open
feat: Exit Button #6763
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
SamTV12345
reviewed
Nov 20, 2024
| helper.exitPad = async () => { | ||
| const button = helper.exitButton(); | ||
| button.trigger('click'); | ||
| await helper.waitForPromise(() => window.location.pathname === '/'); |
There was a problem hiding this comment.
A test would be good for that :)
SamTV12345
reviewed
Nov 20, 2024
| @@ -217,3 +217,7 @@ exports.focusOnLine = (ace) => { | |||
| } | |||
| // End of setSelection / set Y position of editor | |||
| }; | |||
|
|
|||
| // toolbar.registerCommand('exit', () => { | |||
There was a problem hiding this comment.
I think this can be left out
SamTV12345
reviewed
Mar 31, 2025
| @@ -381,6 +381,10 @@ exports.padeditbar = new class { | |||
| $('.exportlink').first().trigger('focus'); | |||
| } | |||
| }); | |||
| this.registerCommand('exit', () => { | |||
| console.log('Exit button clicked'); | |||
There was a problem hiding this comment.
Maybe remove this console.log statement
SamTV12345
requested changes
Mar 31, 2025
| @@ -381,6 +381,10 @@ exports.padeditbar = new class { | |||
| $('.exportlink').first().trigger('focus'); | |||
| } | |||
| }); | |||
| this.registerCommand('exit', () => { | |||
| console.log('Exit button clicked'); | |||
| window.location.href = '/'; | |||
There was a problem hiding this comment.
Also relative url is important for this to work
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This feature adds an exit Button to the top right of the toolbar, making it easy for the user to nav back to the home, initially the user had to edit the browser endpoints inorder to moveback to the home page. now with the exit button it is pretty much a click away!
This is my first OSS contribution, changes are welcome