Skip to content

Conversation

brianignacio5
Copy link
Collaborator

Description

This pull request removes support for several additional frameworks (ESP-MDF, ESP-Matter, ESP-Rainmaker, ESP-HomeKit-SDK) and their related commands, settings, documentation, and localization. It also removes the esp_debug_adapter submodule and associated installation steps. The changes simplify the codebase and documentation by focusing support on ESP-IDF and ESP-ADF.

Note: The ESP-Rainmaker feature removed was the download and install framework. The Rainmaker features in ESP-IDF Explorer tabs (to see and update nodes in your Rainmaker account, are still there).

Key changes:

Framework and Submodule Removal:

  • Removed the esp_debug_adapter submodule and all references to it, including its entry in .gitmodules and related installation steps in GitHub Actions scripts. (.gitmodules, esp_debug_adapter, .github/actions/idf/entrypoint.sh, .github/actions/idf/ui-entrypoint.sh, .prettierignore) [1] [2] [3] [4] [5]

Documentation Updates (English and Chinese):

  • Removed documentation and settings references for ESP-MDF, ESP-Matter, ESP-Rainmaker, and ESP-HomeKit-SDK, including installation commands, settings, and descriptions in both English and Chinese docs. (README.md, README_CN.md, docs_espressif/en/commands.rst, docs_espressif/en/settings.rst, docs_espressif/zh_CN/commands.rst, docs_espressif/zh_CN/settings.rst) [1] [2] [3] [4] [5] [6] [7] [8] [9] [10] [11] [12]

Localization Cleanup:

  • Removed all Spanish localization strings related to the removed frameworks, their commands, and settings. (l10n/bundle.l10n.es.json) [1] [2] [3] [4]

Type of change

  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Steps to test this pull request

This PR removes ESP-MDF, ESP-Rainmaker ESP-Matter and ESP-HomeKit and old python debug adapter.

  • Expected behaviour:

Removal of these commands and debug adapter doesn't break other extension features.

  • Expected output:

How has this been tested?

Manual testing of build flash monitor and debug.

Test Configuration:

  • ESP-IDF Version: 5.5.1
  • OS (Windows,Linux and macOS): macOS

Checklist

  • PR Self Reviewed
  • Applied Code formatting
  • Added Documentation
  • Added Unit Test
  • Verified on all platforms - Windows,Linux and macOS

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant