[VSC-1688/1718/1748] Multiple project configuration migration to CMakePresets #1679
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Disable prompts from CMake extension that might confuse the esp-idf users. - Disable autoconfiguration from CMake extension - Remove CMake status bar icons
|
Pull request has been marked as |
radurentea
added
ongoing
- This keeps idfConfiguration.parameterToProjectConfigMap('idf.buildPath') returning the preset’s binaryDir (as buildDirectoryPath) instead of falling back to the default ${workspaceFolder}/build.
- Fixes issue where Set Target invoked idf.py with the wrong -B dir after profile edits or when “Save last project configuration” is enabled.
…s text - Run openocd --version with silent output and coalesce concurrent calls to avoid duplicate banners during set-target/devkit detection/hints. - Store aggregated OpenOCD output as string (text-only) to avoid Buffer typing issues and unnecessary Buffer.concat allocations.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Please include a summary of the change and which issue is fixed.
Fixes #XXX
Type of change
Please delete options that are not relevant.
Steps to test this pull request
Provide a list of steps to test changes in this PR and required output
Expected behaviour:
Expected output:
How has this been tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Test Configuration:
Dependent components impacted by this PR:
Checklist