-
Notifications
You must be signed in to change notification settings - Fork 2
EIM-79 discovery of existing idf installations #102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Important Installation incomplete: to start using Gemini Code Assist, please ask the organization owner(s) to visit the Gemini Code Assist Admin Console and sign the Terms of Services. |
0eeeefa
to
e9f1180
Compare
01c32b3
to
0cc3eb1
Compare
8a4cd87
to
f4c5c90
Compare
97eb695
to
de9d7bd
Compare
59a905c
to
c57a54a
Compare
a714c5d
to
b3659af
Compare
I've tested with eim cli linux x64 I have 2 versions defined in esp-idf.json that i installed with older vscode setup. Running the eim discover does indeed find the setups and add them to eim_idf.json. The activation script does seems to have issues. Please review my Ubuntu terminal output.
Here is my PATH in a different terminal
Regarding the second setup that was found, it seems to be working properly. Here is the steps and output i've used for testing it:
|
b3659af
to
7ef7f72
Compare
c253671
to
69c8f6f
Compare
ok, good point, but i would like to do it in separate ticket if it's ok with you To the 4.X version, the discovery is meant to import every existing version available on user system, if he has some projects still relying on the older version, we should probably not cut them off them |
Ahh... Thanks for the catch! |
The challenge here is - Espressif-IDE doesn't work with 4.x anymore, we need to have 5.0 and higher |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR. I briefly tested it on macOS, and it was able to detect all the ESP-IDF versions installed on my system and add them to the eim json file
Thank you for the changes. After deleting the .espressif directory. I proceed to use eim install from eim-cli-linux-x64-650 to install esp-idf 5.5. The results are unfortunately the same. Although the scripts are generated, the resulting path doesn't seem to work for blink build on each IDF_PATH example for one of the ESP-IDF setups. Use of EIM discovery and v5.4.2 activation script and blink build. TL;DR Works well
Use of ESP-IDF v5.1.6 activation script and blink build.
Please consider that i previously installed v5.5 using EIM and this is already added in eim_idf.json. Interesting enough, seems that xtensa-esp32-elf-gcc used for the EIM provided version is totally the same:
|
079f877
to
9af370a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Incorrect post
07d7535
to
4e42c60
Compare
IDF installed using eim or eclipse can be discovered parsing function for esp_idf.json file added POSIX discovery mvp updated activation script creation improved export paths in old version discovery added tool_set.json file parsing to the discovery returned the parse_tool_set_config back to working state updated according to changes in the scripts location Documentation update to add the discovery command reworked the vscode discovery according to new approach to isntallation removed unused code updated the discovery command help Fixed discovery tools paths improved windows debugging part of discovery and venv creation creating venv using proper python discovery disabled for vscode installed IDF on windows
4e42c60
to
f9d20bb
Compare
Description
Adds the discovery command which will scan the filesystem for existing idf instances and will try to add them to the eim_idf.json file. But it will not fix them, so if it's just repository which was not installed, it will not work.
Supports the discovery of IDF installed previously by VScode.
Supports the discovery of IDF installed previously by Espressif IDE.
documentation updated
rebased
rebased again
rebased on top of new changes
rebased on top of the deduplication fix
waiting for #163 which solves the eclipse issue
rebased on top of last release
rebased on top of 0.2.8
rebased and tested
Related
Testing
Tested discovery of previously instaled IDF using vscode on macos. Sucesfully builded hello world.
Tested discovery of previously instaled IDF using eclipse on macos. Sucesfully builded hello world.
Checklist
Before submitting a Pull Request, please ensure the following: