Skip to content

feat(websocket): Add ws get HTTP response headers #794

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

feat(websocket): Add ws get HTTP response headers #794

wants to merge 1 commit into from

Conversation

glmfe
Copy link
Collaborator

@glmfe glmfe commented Apr 2, 2025

Description

  • Expose HTTP header from the ws upgrade.

Related

@glmfe glmfe force-pushed the feat/add-get-ws-headers branch from 1d870b6 to 6a47539 Compare April 2, 2025 23:52
@glmfe glmfe self-assigned this Apr 2, 2025
@glmfe glmfe requested a review from euripedesrocha April 2, 2025 23:53
@glmfe glmfe added the websocket label Apr 2, 2025
@glmfe glmfe marked this pull request as ready for review April 30, 2025 14:23
@glmfe glmfe force-pushed the feat/add-get-ws-headers branch 2 times, most recently from 2b83ae5 to 9f1299b Compare May 6, 2025 01:34
github-advanced-security[bot]
github-advanced-security bot found potential problems May 6, 2025
View reviewed changes
components/esp_websocket_client/esp_websocket_client.c
.propagate_control_frames = true
.propagate_control_frames = true,
#if WS_TRANSPORT_STORE_RESPONSE_HEADERS
.response_headers = client->config->response_headers,

Check failure

Code scanning / clang-tidy

field designator 'response_headers' does not refer to any field in type 'const esp_transport_ws_config_t' [clang-diagnostic-error] Error

field designator 'response_headers' does not refer to any field in type 'const esp_transport_ws_config_t' [clang-diagnostic-error]
components/esp_websocket_client/esp_websocket_client.c
.propagate_control_frames = true,
#if WS_TRANSPORT_STORE_RESPONSE_HEADERS
.response_headers = client->config->response_headers,
.response_headers_len = client->config->response_headers_len

Check failure

Code scanning / clang-tidy

field designator 'response_headers_len' does not refer to any field in type 'const esp_transport_ws_config_t' [clang-diagnostic-error] Error

field designator 'response_headers_len' does not refer to any field in type 'const esp_transport_ws_config_t' [clang-diagnostic-error]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@euripedesrocha euripedesrocha Awaiting requested review from euripedesrocha

At least 1 approving review is required to merge this pull request.

Assignees

@glmfe glmfe

Labels
websocket
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[websocket]: ability to read connection upgrade headers (IDFGH-14252)
1 participant
@glmfe