Skip to content

Conversation

agocsdaniel
Copy link

@agocsdaniel agocsdaniel commented Oct 17, 2025

I run into a bug while trying to use I2S HAL. It seems that there is a typo in one of the macros being checked. I checked that no other places mention the typoed macro.

@CLAassistant
Copy link

CLAassistant commented Oct 17, 2025

CLA assistant check
All committers have signed the CLA.

Copy link

github-actions bot commented Oct 17, 2025

Messages
📖 🎉 Good Job! All checks are passing!

👋 Hello agocsdaniel, we appreciate your contribution to this project!


📘 Please review the project's Contributions Guide for key guidelines on code, documentation, testing, and more.

🖊️ Please also make sure you have read and signed the Contributor License Agreement for this project.

Click to see more instructions ...


This automated output is generated by the PR linter DangerJS, which checks if your Pull Request meets the project's requirements and helps you fix potential issues.

DangerJS is triggered with each push event to a Pull Request and modify the contents of this comment.

Please consider the following:
- Danger mainly focuses on the PR structure and formatting and can't understand the meaning behind your code or changes.
- Danger is not a substitute for human code reviews; it's still important to request a code review from your colleagues.
- To manually retry these Danger checks, please navigate to the Actions tab and re-run last Danger workflow.

Review and merge process you can expect ...


We do welcome contributions in the form of bug reports, feature requests and pull requests via this public GitHub repository.

This GitHub project is public mirror of our internal git repository

1. An internal issue has been created for the PR, we assign it to the relevant engineer.
2. They review the PR and either approve it or ask you for changes or clarifications.
3. Once the GitHub PR is approved, we synchronize it into our internal git repository.
4. In the internal git repository we do the final review, collect approvals from core owners and make sure all the automated tests are passing.
- At this point we may do some adjustments to the proposed change, or extend it by adding tests or documentation.
5. If the change is approved and passes the tests it is merged into the default branch.
5. On next sync from the internal git repository merged change will appear in this public GitHub repository.

Generated by 🚫 dangerJS against a047b6a

@github-actions github-actions bot changed the title fix(i2s_hal): fix typo in PDM2PCM check fix(i2s_hal): fix typo in PDM2PCM check (IDFGH-16642) Oct 17, 2025
@espressif-bot espressif-bot added the Status: Opened Issue is new label Oct 17, 2025
@suda-morris
Copy link
Collaborator

sha=a047b6af247c5bdad5a6741f2a3ee57d8ad62a1b

@suda-morris suda-morris added the PR-Sync-Merge Pull request sync as merge commit label Oct 17, 2025
@espressif-bot espressif-bot added Status: In Progress Work is in progress and removed Status: Opened Issue is new labels Oct 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

PR-Sync-Merge Pull request sync as merge commit Status: In Progress Work is in progress

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants