-
Notifications
You must be signed in to change notification settings - Fork 7.9k
feat(esp-tls): Update esp_tls CMakeLists.txt and Kconfig for wolfssl (IDFGH-16560) #17683
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
👋 Hello gojimmypi, we appreciate your contribution to this project! 📘 Please review the project's Contributions Guide for key guidelines on code, documentation, testing, and more. 🖊️ Please also make sure you have read and signed the Contributor License Agreement for this project. Click to see more instructions ...
Review and merge process you can expect ...
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the final PR Bugbot will review for you during this billing cycle
Your free Bugbot reviews will reset on October 20
Details
Your team is on the Bugbot Free tier. On this plan, Bugbot will review limited PRs each billing cycle for each member of your team.
To receive Bugbot reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial.
message(STATUS "WOLFSSL_PROJECT_DIR = ${WOLFSSL_PROJECT_DIR}") | ||
message(STATUS "CMAKE_HOME_DIRECTORY = ${CMAKE_HOME_DIRECTORY}") | ||
message(STATUS "WOLFSSL_ROOT = ${WOLFSSL_ROOT}") | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bug: Debug Output and Dependency Hardcoding
This change introduces two issues: accidentally committed debug message(STATUS)
calls, including extensive CMAKE variable output, should be removed. Also, the wolfssl_esp_tls_lib
variable is hardcoded to 'wolfssl' for the REQUIRES
dependency, which conflicts with the dynamic component discovery logic and may cause build issues.
Description
This is the sixth in a series of pull requests to improve wolfSSL integration with the ESP-IDF as proposed in #16145
As there are multiple changes there, it was suggested that I break the update into smaller pieces.
This PR updates the requirements for wolfSSL in the
components/esp-tls/CMakeLists.txt
andcomponents/esp-tls/Kconfig
Related
See:
Testing
The fully-implemented update is on my wolfssl-dev branch. I've been testing with this esp_http_client_example.
See also the published wolfSSL Managed component that already includes the Certificate Bundle feature introduced in wolfSSL/wolfssl#7936
Checklist
Before submitting a Pull Request, please ensure the following:
Note
Improves wolfSSL selection/linkage in
esp-tls
CMake and updates Kconfig (selectsTLS_STACK_WOLFSSL
, addsESP_WOLFSSL_SMALL_CERT_VERIFY
, and build diagnostics).components/esp-tls/CMakeLists.txt
):wolfssl_esp_tls_lib
, includeesp_tls_wolfssl.c
, and add${wolfssl_esp_tls_lib}
toREQUIRES
.esp-wolfssl
locations; linkCOMPONENT_LIB
to detectedwolfssl
.-DWOLFSSL_ESPIDF
and-DWOLFSSL_USER_SETTINGS
.message(STATUS ...)
diagnostics for configuration paths and decisions.components/esp-tls/Kconfig
):select TLS_STACK_WOLFSSL
(replacesdepends on
).ESP_WOLFSSL_SMALL_CERT_VERIFY
(defaulty
) for reduced chain verification.Written by Cursor Bugbot for commit 75df0a7. This will update automatically on new commits. Configure here.