Skip to content

Conversation

Narukara
Copy link

Description

From #17639

  • The word "deferred" is not used to avoid being misleading.
  • Clarify the purpose of mutex.
  • The pointer passed to esp_execute_shared_stack_function does not point to the top of the stack, but to the starting (lowest) address of the stack.

In the Chinese version:

  • 和上面的英文版一致的修改
  • “调用该函数的任何函数”(caller)改为 “该函数调用的任何函数”(callee)
  • 其他翻译优化

Related

Fixes #17639

Testing


Checklist

Before submitting a Pull Request, please ensure the following:

  • 🚨 This PR does not introduce breaking changes.
  • All CI checks (GH Actions) pass.
  • Documentation is updated as needed.
  • Tests are updated or added as necessary.
  • Code is well-commented, especially in complex areas.
  • Git history is clean — commits are squashed to the minimum necessary.

@CLAassistant
Copy link

CLAassistant commented Sep 24, 2025

CLA assistant check
All committers have signed the CLA.

Copy link

Messages
📖 🎉 Good Job! All checks are passing!

👋 Hello Narukara, we appreciate your contribution to this project!


📘 Please review the project's Contributions Guide for key guidelines on code, documentation, testing, and more.

🖊️ Please also make sure you have read and signed the Contributor License Agreement for this project.

Click to see more instructions ...


This automated output is generated by the PR linter DangerJS, which checks if your Pull Request meets the project's requirements and helps you fix potential issues.

DangerJS is triggered with each push event to a Pull Request and modify the contents of this comment.

Please consider the following:
- Danger mainly focuses on the PR structure and formatting and can't understand the meaning behind your code or changes.
- Danger is not a substitute for human code reviews; it's still important to request a code review from your colleagues.
- To manually retry these Danger checks, please navigate to the Actions tab and re-run last Danger workflow.

Review and merge process you can expect ...


We do welcome contributions in the form of bug reports, feature requests and pull requests via this public GitHub repository.

This GitHub project is public mirror of our internal git repository

1. An internal issue has been created for the PR, we assign it to the relevant engineer.
2. They review the PR and either approve it or ask you for changes or clarifications.
3. Once the GitHub PR is approved, we synchronize it into our internal git repository.
4. In the internal git repository we do the final review, collect approvals from core owners and make sure all the automated tests are passing.
- At this point we may do some adjustments to the proposed change, or extend it by adding tests or documentation.
5. If the change is approved and passes the tests it is merged into the default branch.
5. On next sync from the internal git repository merged change will appear in this public GitHub repository.

Generated by 🚫 dangerJS against d3fe7a6

@github-actions github-actions bot changed the title docs(shared_stack): Fix incorrect or misleading expressions docs(shared_stack): Fix incorrect or misleading expressions (IDFGH-16521) Sep 24, 2025
@espressif-bot espressif-bot added the Status: Opened Issue is new label Sep 24, 2025
@KonstantinKondrashov
Copy link
Collaborator

sha=d3fe7a6ea143bba46fa934ded8b757b3f9b80069

@KonstantinKondrashov KonstantinKondrashov added the PR-Sync-Merge Pull request sync as merge commit label Oct 1, 2025
@espressif-bot espressif-bot added Status: Reviewing Issue is being reviewed and removed Status: Opened Issue is new labels Oct 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

PR-Sync-Merge Pull request sync as merge commit Status: Reviewing Issue is being reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

esp_execute_shared_stack_function Documentation Issue & Alternative Approach (IDFGH-16500)

4 participants