Skip to content

Conversation

piratagit
Copy link

@piratagit piratagit commented Aug 16, 2025

Description

Congrats for the great work, big fan here !
I was studying with the Bluetooth examples, and notice that this script was suppose to check if was written on an specific GATT attribute the value ON or OFF, and turn on/ off the led, but the code was only checking if was written any value on the attribute and the OFF wasn't working. I corrected the main/main.c file and it worked, but I notice too that when the device starts, starts with the led GREEN, but when you write the attribute to turn OFF, them ON, the device turn ON in a white color led, so I changed the main/src/led.c file too, to make it turn GREEN when you apply the command, the same color as when the device starts.

Related

Testing

Build on idf.py, flashed and tested on esp32c6

Checklist

Before submitting a Pull Request, please ensure the following:

  • 🚨 This PR does not introduce breaking changes.
  • All CI checks (GH Actions) pass.
  • Documentation is updated as needed.
  • Tests are updated or added as necessary.
  • Code is well-commented, especially in complex areas.
  • Git history is clean — commits are squashed to the minimum necessary.

Copy link

github-actions bot commented Aug 16, 2025

Messages
📖 🎉 Good Job! All checks are passing!

👋 Hello piratagit, we appreciate your contribution to this project!


📘 Please review the project's Contributions Guide for key guidelines on code, documentation, testing, and more.

🖊️ Please also make sure you have read and signed the Contributor License Agreement for this project.

Click to see more instructions ...


This automated output is generated by the PR linter DangerJS, which checks if your Pull Request meets the project's requirements and helps you fix potential issues.

DangerJS is triggered with each push event to a Pull Request and modify the contents of this comment.

Please consider the following:
- Danger mainly focuses on the PR structure and formatting and can't understand the meaning behind your code or changes.
- Danger is not a substitute for human code reviews; it's still important to request a code review from your colleagues.
- To manually retry these Danger checks, please navigate to the Actions tab and re-run last Danger workflow.

Review and merge process you can expect ...


We do welcome contributions in the form of bug reports, feature requests and pull requests via this public GitHub repository.

This GitHub project is public mirror of our internal git repository

1. An internal issue has been created for the PR, we assign it to the relevant engineer.
2. They review the PR and either approve it or ask you for changes or clarifications.
3. Once the GitHub PR is approved, we synchronize it into our internal git repository.
4. In the internal git repository we do the final review, collect approvals from core owners and make sure all the automated tests are passing.
- At this point we may do some adjustments to the proposed change, or extend it by adding tests or documentation.
5. If the change is approved and passes the tests it is merged into the default branch.
5. On next sync from the internal git repository merged change will appear in this public GitHub repository.

Generated by 🚫 dangerJS against 12ea190

@github-actions github-actions bot changed the title fix(examples): Modified code to led turn on/off properly fix(examples): Modified code to led turn on/off properly (IDFGH-16294) Aug 16, 2025
@espressif-bot espressif-bot added the Status: Opened Issue is new label Aug 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Status: Opened Issue is new

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants