fix: respect build directory in idf extension #55
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, the idf.py reconfigure command is executed using only the build directory's basename, ignoring the -B argument provided by the user when running idf.py clang-check. For instance, executing `idf.py -B builds/mybuild clang-check` results in the reconfigure command being called as `idf.py -B mybuild reconfigure`. Since the basename appears to have no impact on the outcome, this update removes it. ``` idf.py -D IDF_TOOLCHAIN=clang -B build/mybuild set-target esp32 idf.py -B build/mybuild clang-check ``` Closes espressif#54 Signed-off-by: Frantisek Hrbata <frantisek.hrbata@espressif.com>
3 tasks
peterdragun
approved these changes
Apr 28, 2025
|
Thank you for the fix and the reviews! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently, the idf.py reconfigure command is executed using only the build directory's basename, ignoring the -B argument provided by the user when running idf.py clang-check. For instance, executing
idf.py -B builds/mybuild clang-checkresults in the reconfigure command being called asidf.py -B mybuild reconfigure.Since the basename appears to have no impact on the outcome, this update removes it.
Related
Fixes #54
Testing
Checklist
Before submitting a Pull Request, please ensure the following: