-
Notifications
You must be signed in to change notification settings - Fork 6
Feat/ Espressif clang check and remove unwanted python traceback (IDF-11835) #52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
4f68206
to
ba7cd98
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, maybe checking for clang-tidy
instead of clang
would be more relevant, since IIUC it's the clang-tidy
which is call under the hood. It's just nitpick, no need to change it. Thank you
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@mfialaf Thank you. LGTM in general. Could you please classify these commits as fixes instead of features? |
ba7cd98
to
4b28d41
Compare
@dobairoland @fhrbata @radimkarnis Thank you all for revirew! I considered your comments and adjusted the code. PR should be ready. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mfialaf Could you please correct the typo in the commit title in traceback?
Also, why is Espressif before clang-tidy? clang-tidy is not developed by Espressif.
4b28d41
to
1e86710
Compare
Uh oh!
There was an error while loading. Please reload this page.