fix: Windows - run-clang-tidy.py not found in your PATH (IDFGH-14140)

[mfialaf]

The bug causes the shutil.which() function on Windows. When used, it tries to append all possible extensions to the searched command from os.environ['PATHEXT']. Since the searched command is run-clang-tidy without extension, the search fails.

https://docs.python.org/3/library/shutil.html#shutil.which

Adding '.' to PATHEXT ensures to find the full path to run-clang-tidy.

As stated in the documentation, lookup for files without extension works in Python 3.12, without modification.

[fhrbata]

@mfialaf LGTM, I'm wondering if adding . to the PATHEXT would solve this also.

[peterdragun]

LGTM, I would try to add . to PATHEXT as well, but I am also okay with the proposed solution. Thank you!

[mfialaf]

@fhrbata While debugging I've tried to extend the PATHEXT just by ;.
So the result was .COM;.EXE;.BAT;.CMD;.VBS;.VBE;.JS;.JSE;.WSF;.WSH;.MSC;.CPL;

The added dot did not come to my mind. Good point, it works!

[mfialaf]

Thank you @fhrbata and @dobairoland for reviewing and @peterdragun for help with debugging setup.
I adjusted the code with a new approach. PTAL

[fhrbata]

@mfialaf Thank you for trying it. Still LGTM. Thanks

[dobairoland]

@mfialaf Thank you. Could you please make a release as well so we can integrate this fix back to ESP-IDF?