Skip to content

feat: Drop support for ESP-IDF 4.4 and Python 3.6 #49

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 16, 2024

Conversation

peterdragun
Copy link
Collaborator

@peterdragun peterdragun commented Sep 11, 2024

Description

This MR includes several fixes for the pipeline to pass:

Reasons to drop ESP-IDF 4.4

TLDR: dependency hell

I was trying to make the pipeline work on the latest IDF, but there was a conflict with the pygments package because IDF required >=3.13. The requirement is coming from the codereport package, so I fixed that upstream and wanted to update the version here to match at least that version (codereport>=0.4.0).
Then I realized that we are still stuck with codereport version 0.2.5, because of Jinja2. The newest versions of codereport (3.1+) require Jinja2==3.1.1, but ESP-IDF has this requirement set to <3.1, so there was no way to satisfy both ESP-IDF 4.4 and the latest versions.

Considering that ESP-IDF 4.4 is not supported anymore, this is IMO the best solution.

This is now working in the CI with IDF 5.0+, but if we hit some dependency issue again we should remove the dependency on the codereport package, there is not a lot of code, mostly just templates for HTML, so we should consider implementing this ourselves.

Related

Internal tracker: IDF-10919

@peterdragun peterdragun force-pushed the update_codereport branch 2 times, most recently from 1bdd37c to e67c467 Compare September 11, 2024 08:30
@peterdragun peterdragun changed the title fix: update codereport version to allow usage of pygments 2.12+ feat: Drop support for ESP-IDF 4.4 and Python 3.6 Sep 11, 2024
Copy link
Collaborator

@fhrbata fhrbata left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you for looking into this.

Copy link
Collaborator

@dobairoland dobairoland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Nice work!

Copy link
Member

@hfudev hfudev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you!

@peterdragun
Copy link
Collaborator Author

@dobairoland PTAL, this should be ready to merge.

@dobairoland dobairoland merged commit bbcaaf5 into espressif:master Sep 16, 2024
4 checks passed
@peterdragun peterdragun deleted the update_codereport branch September 16, 2024 07:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants