feat: Drop support for ESP-IDF 4.4 and Python 3.6 #49
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This MR includes several fixes for the pipeline to pass:
Reasons to drop ESP-IDF 4.4
TLDR: dependency hell
I was trying to make the pipeline work on the latest IDF, but there was a conflict with the
pygments
package because IDF required>=3.13
. The requirement is coming from thecodereport
package, so I fixed that upstream and wanted to update the version here to match at least that version (codereport>=0.4.0).Then I realized that we are still stuck with codereport version 0.2.5, because of
Jinja2
. The newest versions of codereport (3.1+) requireJinja2==3.1.1
, but ESP-IDF has this requirement set to<3.1
, so there was no way to satisfy both ESP-IDF 4.4 and the latest versions.Considering that ESP-IDF 4.4 is not supported anymore, this is IMO the best solution.
This is now working in the CI with IDF 5.0+, but if we hit some dependency issue again we should remove the dependency on the
codereport
package, there is not a lot of code, mostly just templates for HTML, so we should consider implementing this ourselves.Related
Internal tracker: IDF-10919