fix(net): Rework NO_GLOBALS to not act on dependent network classes #11933
+4
−6
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request standardizes the way global instances are conditionally defined across several network-related libraries. Specifically, it ensures that global objects like
WiFi
,ETH
,PPP
,Network
, andMDNS
are only instantiated when the appropriate macros are not defined, improving consistency and configurability throughout the codebase.Conditional global instance definitions:
#if !defined(NO_GLOBAL_INSTANCES) && !defined(NO_GLOBAL_ETH)
guard around the globalETH
instance inETH.cpp
for consistency with other modules.#if !defined(NO_GLOBAL_INSTANCES) && !defined(NO_GLOBAL_PPP)
guard around the globalPPP
instance inPPP.cpp
.WiFi
,Network
, andMDNS
are only declared when the appropriate macros are not defined in their respective header files (WiFi.h
,NetworkManager.h
,ESPmDNS.h
). [1] [2] [3]Closes: #11871