Support resources of arbitrary size in rebar3 #2956
Conversation
| -spec get_resource_type(tuple(), [resource()]) -> {ok, resource()}. | ||
| get_resource_type(Source, Resources) when tuple_size(Source) > 0 -> | ||
| Type = element(1, Source), | ||
| get_resource(Type, Source, Resources); |
There was a problem hiding this comment.
Location and Source aren't the same. In some cases the Location is pulled out of the tuple.
There was a problem hiding this comment.
Thanks for the feedback! The reason I originally flattened everything is that a custom resource of size 2-4 can have whatever it likes in its tuple elements, so I thought that being picky about Source and Location is maybe too specific, especially if all this generates is an error message (which may not be the case).
I restored the existing clauses, and merely extended the size 6 case to cover all sizes > 4. The main motivation for the PR is to properly add support a custom resource I am using for some private code, which needs 5 args and previously raised a mere Failed to fetch and copy dep:.
Removes arbitrary restriction to 2, 3, 4, or 6-element tuples for (possibly custom) resource specifications.
aronisstav
force-pushed
the
feature/allow-resources-of-any-size
branch
from
f8af7eb to
54ce6ce
Compare
Removes arbitrary restriction to 2, 3, 4, or 6-element tuples for (possibly custom) resource specifications.